Skip to content

Updated AutomationId from Thickness to BrushSize #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

q587p
Copy link

@q587p q587p commented Sep 3, 2019

Now “Thickness, pixels” have different AutomationId, updated sample with current one.

@hassanuz
Copy link
Contributor

Hi @q587p,

Is the DrawWithPen test being successfully completed for you? The last Assert is failing on my end Assert.IsTrue(undoButton.Enabled);
Because the rectangle isn't being drawn. We'd probably have to rework the sample further.

@q587p
Copy link
Author

q587p commented Sep 19, 2019

Hi @hassanuz

Rechecked – yes, all tests work, except the first – DrawWithPen (although at first run the Paint window opened on the wrong monitor and all the tests failed, but this is not so critical, as for me).

The test does not draw anything, respectively, the canvas is empty and the Undo button is not active.

In my tests, I just don’t work (yet?) with all this AddAction/PerformActions flow and it’s hard to understand what the problem is.

P. S. Seems like PointerKind.Pen don't work as draw tool in current Windows build. Maybe it must be enabled somehow? Or should we have it in real (like hardware) for this test?

P. P. S. I'll try to find a stylus and check if this is the case.

@vuthanhnam
Copy link

Hi @hassanuz

Rechecked – yes, all tests work, except the first – DrawWithPen (although at first run the Paint window opened on the wrong monitor and all the tests failed, but this is not so critical, as for me).

The test does not draw anything, respectively, the canvas is empty and the Undo button is not active.

In my tests, I just don’t work (yet?) with all this AddAction/PerformActions flow and it’s hard to understand what the problem is.

P. S. Seems like PointerKind.Pen don't work as draw tool in current Windows build. Maybe it must be enabled somehow? Or should we have it in real (like hardware) for this test?

P. P. S. I'll try to find a stylus and check if this is the case.

Hi,

I have the same issue. Did you get that resolved?
Thanks.
Nam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants