Updating nuget packages + small cleanup #1796
Open
+72
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niels9001
commented
Mar 7, 2025
niels9001
commented
- Update NugetPackages
- Cleaning up App.xaml.cs by moving helpers
niels9001
changed the title
There was a problem hiding this comment.
PR Overview
This PR updates NuGet packages and cleans up App.xaml.cs by moving helper methods into dedicated helper classes. Key changes include:
- Creating VersionHelper.cs and EnumHelper.cs to encapsulate version information and enum parsing logic.
- Refactoring usage in App.xaml.cs, SettingsPage.xaml.cs, HomePage.xaml.cs, ThemeHelper.cs, and TitleBarPage.xaml.cs to use the new helper methods.
- Removing duplicate helper code from App.xaml.cs to clean up the application startup code.
Reviewed Changes
| File | Description |
|---|---|
| WinUIGallery/Helpers/VersionHelper.cs | New file for version details with dynamic runtime info retrieval. |
| WinUIGallery/Helpers/EnumHelper.cs | New file for enum parsing logic, replacing duplicate implementations. |
| WinUIGallery/App.xaml.cs | Removed duplicated version and enum conversion code, now relying on helper classes. |
| WinUIGallery/Helpers/ThemeHelper.cs | Refactored to use EnumHelper for converting strings to enums. |
| WinUIGallery/Pages/SettingsPage.xaml.cs | Updated to use VersionHelper and EnumHelper for version and enum handling. |
| WinUIGallery/Pages/HomePage.xaml.cs | Updated to use VersionHelper for displaying version details. |
| WinUIGallery/Samples/ControlPages/TitleBarPage.xaml.cs | Refactored enum conversion to use EnumHelper for title bar height option. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
marcelwgn
requested changes
Mar 10, 2025
|
/azp run |
1 similar comment
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.