WinUIGallery Submodule Update in WinUI3: Fixes #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kythant
changed the title
|
/azp run |
|
/azp run |
marcelwgn
reviewed
Mar 12, 2025
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>x64</Platform> |
There was a problem hiding this comment.
Why should ARM64-ec point to x64 and not ARM?
There was a problem hiding this comment.
arm64ec and x64 are interchangeable. Arm64ec is basically x64 under the hood but with arm64
We were also running into this error that setting the pubxml to point to x64 runtime identifier solves.
C:\ProgramFiles\dotnet\sdk\9.0.200\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(107,5): error NETSDK1083: The specified RuntimeIdentifier 'win-arm64ec' is not recognized. See https://aka.ms/netsdk1083 for more information. [C:__w\1\s\Samples\WinUIGallery\WinUIGallery.UnitTests\WinUIGallery.UnitTests.csproj]
karkarl
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various fixes to be able to update the WinUIGallery's Submodule in WinUI3.
Motivation and Context
We should update WinUI3 to use the main branch of WinUIGallery. Currently it is on a stale topic branch.
How Has This Been Tested?
Ran in the PR pipelines with the submodule updated
Screenshots (if appropriate):
Types of changes