Skip to content

Improved source quality in the test projects #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0x5bfa
Copy link
Contributor

@0x5bfa 0x5bfa commented Apr 22, 2025

Description

As the title.

Please enable this option to hide space to tab changes.

image

Motivation and Context

The code quality in the test projects was not as good and so, improved it to be consistent.

How Has This Been Tested?

  • Build the test projects

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@0x5bfa
Copy link
Contributor Author

0x5bfa commented Apr 22, 2025

Are you guys wanting to use Tabs instead of Spaces for indentation in C#? in XAML, I think Tabs is prefered?

@marcelwgn
Copy link
Contributor

Are you guys wanting to use Tabs instead of Spaces for indentation in C#? in XAML, I think Tabs is prefered?

We want to stick with what XAML Styler does per default which seems to be spaces for the properties: https://github.com/Xavalon/XamlStyler/wiki/External-Configurations#indent-with-tabs
Plan is to eventually start using XAML Styler for this repo but we are blocked on property ordering issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants