Skip to content

chore: use cargo-wdk to build & package samples on the CI pipeline #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

krishnakumar4a4
Copy link

@krishnakumar4a4 krishnakumar4a4 commented Apr 15, 2025

This PR aims to use cargo-wdk to build and package the driver samples in the repository on the CI pipeline.
Changes:

  1. Added continue-on-error = true to the build job. Without this change, one job failure cancels all the other jobs triggered in the matrix. Since other jobs are being cancelled, we won't be able to know the possible failures/successes of those jobs while most of them have executed 70% of the steps at any given time.
  2. Added continue-on-error = true to the "Build and Package Sample Drivers in the workspace with cargo-wdk" step as cargo-wdk fails for known reasons due to a mix of sample and non-sample drivers in the workspace. cargo-wdk currently can work with one kind of setup, either all are sample drivers or none.
  3. Note: The cargo-wdk used in the pipeline is taken from https://github.com/svasista-ms/windows-drivers-rs and from integrate-cargo-wdk branch as this PR is still not merged. This pipeline needs to get updated with cargo-wdk from https://github.com/microsoft/windows-drivers-repo once it is merged.

About cargo-wdk

cargo-wdk is a Command-Line Interface (CLI) utility that can be used to create and build Windows driver projects that depend on the WDK and windows-drivers-rs platform. It aims to streamline management of Rust drivers. It provides an easy and a consistent way to get started with Rust driver projects and build them using simple commands. It eliminates a lengthy setup process and also the need to maintain additional files/tools (Makefiles for cargo-make) to build/package the drivers.

Note: cargo-wdk is yet to be merged into windows-drivers-rs repo and it under review here

@krishnakumar4a4 krishnakumar4a4 force-pushed the feat/integrate-cargo-wdk branch from 8fff09f to 3bcd9b1 Compare April 16, 2025 09:54
…sample drivers in workspace, so continuing on error so that cargo make can still be executed
@krishnakumar4a4
Copy link
Author

@krishnakumar4a4 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant