Skip to content

56138352: Use the global default version of LKG compiler #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

alexlamtest
Copy link
Contributor

@alexlamtest alexlamtest commented Mar 6, 2025

Use the version of LKG compiler specified by the Agg repo as the global default (file build\AzurePipelinesTemplates\WindowsAppSDK-Global-LKGVersions.yml), unless a different version is specified as a repo-local override (in local file WindowsAppSDK-CommonVariables.yml).

Here's a summary of how the branch being used on this WindowsAppSDK repo determines the branch being used on the Agg repo for accessing the file WindowsAppSDK-Global-LKGVersions.yml:

  • WindowsAppSDK : Main --> Agg: Main, this is likely the majority case.
  • WindowsAppSDK : release-1.x --> Agg: release-1.x, when x is >= 8, i.e., for servicing branches new enough to support this mechanism, the servicing branch continue to use the LKG compiler version specified by the WindowsAppSDK-Global-LKGVersions.yml file on the Agg repo to build participating feeder repos.
  • WindowsAppSDK : release-1.x --> Agg: Main, when x is <8. For those old servicing branches on Agg that don't contain have the WindowsAppSDK-CommonVariables.yml file, redirect to Agg: Main to avoid "file not found" error during yml parsing. At runtime, the local WindowsAppSDK-CommonVariables.yml file on the WindowsAppSDK repo specifies the LKG compiler version to use, ignoring the global default set in the Agg: Main branch.
  • WindowsAppSDK : private branch --> Agg: Main, by default. That's because for most private branches on the WindowsAppSDK repo, the developer would not have a corresponding private branch on the Agg repo. But in case the developer does want to use a corresponding private branch on the Agg repo, in the private branch on the WindowsAppSDK repo, changing
    build/AzurePipelinesTemplates/WindowsAppSDK-Global-LKGVersions.yml@WindowsAppSDKAggregatorMainBranch to
    build/AzurePipelinesTemplates/WindowsAppSDK-Global-LKGVersions.yml@WindowsAppSDKAggregatorSourceBranch should get the desired behavior.

//////////////////////////////////////

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@alexlamtest
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@alexlamtest
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexlamtest alexlamtest marked this pull request as ready for review March 14, 2025 01:00
@alexlamtest
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexlamtest alexlamtest marked this pull request as draft March 19, 2025 01:25
@alexlamtest
Copy link
Contributor Author

Putting this PR on hold because we are exploring the option of creating servicing branches on the Config repo, which will enable us to move the yml file which specifies the global default LKG compiler version from the Agg repo to the Config repo. If we indeed opt to go that way, this PR will require updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant