Pipeline Performance Optimization: Make Static Analysis Run Parallelly with Build

build/AzurePipelinesTemplates/WindowsAppSDK-Build-Per-Platform-Stage.yml

@@ -5,15 +5,18 @@ parameters:
 - name: "IsOneBranch"
   type: boolean
   default: true
-- name: runStaticAnalysis
+- name: runApiScan
   type: boolean
   default: true
+- name: runPREfast
+  type: boolean
+  default: false
 - name: buildPlatform
   type: string
   default: x64
 
 stages:
-- stage: ${{ format('Build_{0}', parameters.buildPlatform) }}
+- stage: ${{ format(iif(parameters.runPREfast, 'PREfast_{0}', 'Build_{0}'), parameters.buildPlatform) }}
   # Skip the build job if we are reusing the output of a previous build.
   # useBuildOutputFromBuildId variable is set on the Pipeline at Queue time.
   condition:
@@ -50,7 +53,7 @@ stages:
       - name: ob_artifactBaseName
         value: "FoundationBinaries_$(buildConfiguration)_$(buildPlatform)"
       - name: ob_sdl_apiscan_enabled
-        ${{ if parameters.runStaticAnalysis }}:
+        ${{ if parameters.runApiScan }}:
           value: true
         ${{ else }}:
           value: false
@@ -83,7 +86,8 @@ stages:
       parameters:
         SignOutput: ${{ parameters.SignOutput }}
         IsOneBranch: ${{ parameters.IsOneBranch }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+        runApiScan: ${{ parameters.runApiScan }}
+        runPREfast: ${{ parameters.runPREfast }}
 
     # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
     # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-
@@ -125,7 +129,7 @@ stages:
       - name: ob_artifactBaseName
         value: "MrtBinaries_$(buildConfiguration)_$(buildPlatform)"
       - name: ob_sdl_apiscan_enabled
-        ${{ if parameters.runStaticAnalysis }}:
+        ${{ if parameters.runApiScan }}:
           value: true
         ${{ else }}:
           value: false
@@ -158,7 +162,8 @@ stages:
       parameters:
         SignOutput: ${{ parameters.SignOutput }}
         IsOneBranch: ${{ parameters.IsOneBranch }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+        runPREfast : ${{ parameters.runPREfast }}
+        runApiScan : ${{ parameters.runApiScan }}
 
     # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
     # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-

build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml

@@ -5,12 +5,15 @@ parameters:
 - name: "IsOneBranch"
   type: boolean
   default: true
-- name: runStaticAnalysis
+- name: runApiScan
   type: boolean
   default: true
+- name: runPREfast
+  type: boolean
+  default: false
 
 stages:
-- stage: Build_AnyCPU
+- stage: ${{ iif(parameters.runPREfast, 'PREfast_AnyCPU', 'Build_AnyCPU') }}
   # Skip the build job if we are reusing the output of a previous build.
   # useBuildOutputFromBuildId variable is set on the Pipeline at Queue time.
   condition:
@@ -44,9 +47,9 @@ stages:
       ob_outputDirectory: '$(REPOROOT)\out'
       ob_sdl_codeSignValidation_excludes: '-|**\Release\**'
       ob_artifactBaseName: "FoundationBinaries_release_anycpu"
-      ${{ if parameters.runStaticAnalysis }}:
+      ${{ if parameters.runApiScan }}:
         ob_sdl_apiscan_enabled: true
-      ${{ if not( parameters.runStaticAnalysis ) }}:
+      ${{ if not( parameters.runApiScan ) }}:
         ob_sdl_apiscan_enabled: false
       ob_sdl_apiscan_softwareFolder: '$(build.SourcesDirectory)\BuildOutput\Release\AnyCPU'
       ob_sdl_apiscan_symbolsFolder: '$(build.SourcesDirectory)\BuildOutput\Release\AnyCPU;SRV*https://symweb.azurefd.net'
@@ -55,7 +58,7 @@ stages:
       parameters:
         SignOutput: ${{ parameters.SignOutput }}
         IsOneBranch: ${{ parameters.IsOneBranch }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+        runPREfast : ${{ parameters.runPREfast }}
 
     # This is a temporarily workaround to avoid getting non-fatal "folder C:\__t\NativeCompilerPrefast not found"
     # errors from the Guardian PREfast task, which shouldn't even be run in the first place, because its pre-
@@ -65,23 +68,28 @@ stages:
       displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'
 
 # extract BuildFoundation and BuildMRT into WindowsAppSDK-Build-Stage-Per-Platform.yml. Separate the build stage per platform
-- template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
-  parameters:
-    SignOutput: ${{ parameters.SignOutput }}
-    IsOneBranch: ${{ parameters.IsOneBranch }}
-    runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
-    BuildPlatform: x86
 
 - template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
   parameters:
     SignOutput: ${{ parameters.SignOutput }}
     IsOneBranch: ${{ parameters.IsOneBranch }}
-    runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+    runPREfast : ${{ parameters.runPREfast }}
+    runApiScan : ${{ parameters.runApiScan }}
     BuildPlatform: x64
 
-- template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
-  parameters:
-    SignOutput: ${{ parameters.SignOutput }}
-    IsOneBranch: ${{ parameters.IsOneBranch }}
-    runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
-    BuildPlatform: arm64
+- ${{ if not(parameters.runPREfast) }}:
+  - template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
+    parameters:
+      SignOutput: ${{ parameters.SignOutput }}
+      IsOneBranch: ${{ parameters.IsOneBranch }}
+      runPREfast : ${{ parameters.runPREfast }}
+      runApiScan : ${{ parameters.runApiScan }}
+      BuildPlatform: x86
+
+  - template: WindowsAppSDK-Build-Per-Platform-Stage.yml@self
+    parameters:
+      SignOutput: ${{ parameters.SignOutput }}
+      IsOneBranch: ${{ parameters.IsOneBranch }}
+      runPREfast : ${{ parameters.runPREfast }}
+      runApiScan : ${{ parameters.runApiScan }}
+      BuildPlatform: arm64

build/AzurePipelinesTemplates/WindowsAppSDK-BuildFoundation-AnyCPU-Steps.yml

@@ -5,9 +5,9 @@ parameters:
 - name: "IsOneBranch"
   type: boolean
   default: true
-- name: runStaticAnalysis
+- name: runPREfast
   type: boolean
-  default: true
+  default: false
 
 steps:
 - task: NuGetAuthenticate@1
@@ -30,7 +30,7 @@ steps:
     filePath: 'BuildAll.ps1'
     arguments: -AzureBuildStep "BuildAnyCPU"
 
-- ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
+- ${{ if eq(parameters.runPREfast, 'true') }}:
   - task: SDLNativeRules@3
     displayName: Run PREfast SDL Native Rules
     inputs:

build/AzurePipelinesTemplates/WindowsAppSDK-BuildFoundation-Steps.yml

@@ -5,9 +5,12 @@ parameters:
 - name: "IsOneBranch"
   type: boolean
   default: true
-- name: runStaticAnalysis
+- name: runApiScan
   type: boolean
   default: true
+- name: runPREfast
+  type: boolean
+  default: false
 
 steps:
 - task: NuGetAuthenticate@1
@@ -71,7 +74,7 @@ steps:
     filePath: 'BuildAll.ps1'
     arguments: -Platform "$(buildPlatform)" -Configuration "$(buildConfiguration)" -AzureBuildStep "BuildFoundation"
 
-- ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
+- ${{ if eq(parameters.runPREfast, 'true') }}:
   - task: SDLNativeRules@3
     displayName: Run PREfast SDL Native Rules
     condition: and(succeeded(), eq(variables['buildConfiguration'], 'Release'), eq(variables['buildPlatform'], 'x64'))
@@ -86,6 +89,7 @@ steps:
       SYSTEM_ACCESSTOKEN: $(System.AccessToken)
     continueOnError: true
 
+- ${{ if eq(parameters.runApiScan, 'true') }}:
   # Copy build output to folder APIScanTarget for APIScan to scan later, in the mean time, exclude some folders/files.
   - task: CopyFiles@2
     displayName: Populate APIScanTarget

build/AzurePipelinesTemplates/WindowsAppSDK-BuildMRT-Steps.yml

@@ -5,9 +5,12 @@ parameters:
 - name: "IsOneBranch"
   type: boolean
   default: true
-- name: runStaticAnalysis
+- name: runApiScan
   type: boolean
   default: true
+- name: runPREfast
+  type: boolean
+  default: false
 
 steps:
 - template: WindowsAppSDK-SetupBuildEnvironment-Steps.yml
@@ -32,7 +35,7 @@ steps:
     filePath: 'BuildAll.ps1'
     arguments: -Platform "$(buildPlatform)" -Configuration "$(buildConfiguration)" -AzureBuildStep "BuildMRT"
 
-- ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
+- ${{ if eq(parameters.runPREfast, 'true') }}:
   - task: SDLNativeRules@3
     displayName: Run PREfast SDL Native Rules
     condition: and(succeeded(), eq(variables['buildPlatform'], 'x64'), eq(variables['buildConfiguration'], 'Release'))
@@ -47,6 +50,7 @@ steps:
       SYSTEM_ACCESSTOKEN: $(System.AccessToken)
     continueOnError: true
 
+- ${{ if eq(parameters.runApiScan, 'true') }}:
   # Copy build output to folder APIScanTarget for APIScan to scan, in the mean time, exclude some folders/files.
   - task: CopyFiles@2
     displayName: Populate APIScanTarget

build/AzurePipelinesTemplates/WindowsAppSDK-PackTransportPackage-Stage.yml

@@ -272,4 +272,4 @@ stages:
           verbosityPush: 'Detailed'
           nuGetFeedType: 'internal'
           #Note: The project qualifier is always required when using a feed name. Also, do not use organization scoped feeds.
-          publishVstsFeed: 'ProjectReunion/Project.Reunion.nuget.internal'
+          publishVstsFeed: 'ProjectReunion/Project.Reunion.nuget.internal'

build/AzurePipelinesTemplates/WindowsAppSDK-Publish-Stage.yml

@@ -27,4 +27,4 @@ stages:
     - template: AzurePipelinesTemplates/WindowsAppSDK-PublishToMaestro-Steps.yml@WindowsAppSDKConfig
       parameters:
         NuGetArtifactNames:
-        - 'TransportPackage'
+        - 'TransportPackage'

build/AzurePipelinesTemplates/WindowsAppSDK-RunTestsInPipeline-Job.yml

@@ -62,4 +62,4 @@ jobs:
         buildPlatform: $(buildPlatform)
         buildConfiguration: $(buildConfiguration)
         testLocale: $(testLocale)
-        ImageName: $(imageName)
+        ImageName: $(imageName)

build/AzurePipelinesTemplates/WindowsAppSDK-Test-Stage.yml

@@ -27,4 +27,4 @@ stages:
     parameters:
       jobName: PipelineTests
       testMatrix: ${{ parameters.testMatrix }} # testMatrix is supplied by WindowsAppSDKConfig/WindowsAppSDK-Foundation-TestConfig.yml
-      buildPlatform: arm64
+      buildPlatform: arm64

build/ProjectReunion-BuildFoundation.yml

@@ -31,6 +31,15 @@ stages:
   parameters:
     SignOutput: false
     IsOneBranch: false
+    runApiScan: true
+    runPREFast: false
+
+- template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
+  parameters:
+    SignOutput: false
+    IsOneBranch: false
+    runApiScan: false
+    runPREFast: true
 
 - template: AzurePipelinesTemplates\WindowsAppSDK-Test-Stage.yml@self
   parameters:

build/WindowsAppSDK-Foundation-Nightly.yml

@@ -115,7 +115,15 @@ extends:
     - template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
       parameters:
         SignOutput: ${{ parameters.SignOutput }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+        runApiScan: ${{ parameters.runStaticAnalysis }}
+        runPREFast: false
+
+    - ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
+      - template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
+        parameters:
+          SignOutput: ${{ parameters.SignOutput }}
+          runApiScan: false
+          runPREFast: true
 
     - template: AzurePipelinesTemplates\WindowsAppSDK-PackTransportPackage-Stage.yml@self
       parameters:

build/WindowsAppSDK-Foundation-Official.yml

@@ -97,10 +97,19 @@ extends:
         break: false
 
     stages:
+
     - template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
       parameters:
         SignOutput: ${{ parameters.SignOutput }}
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+        runApiScan: ${{ parameters.runStaticAnalysis }}
+        runPREFast: false
+
+    - ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
+      - template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
+        parameters:
+          SignOutput: ${{ parameters.SignOutput }}
+          runApiScan: false
+          runPREFast: true
 
     - template: AzurePipelinesTemplates\WindowsAppSDK-PackTransportPackage-Stage.yml@self
       parameters:

build/WindowsAppSDK-Foundation-PR.yml

@@ -92,7 +92,15 @@ extends:
     - template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
       parameters:
         SignOutput: false
-        runStaticAnalysis : ${{ parameters.runStaticAnalysis }}
+        runApiScan: ${{ parameters.runStaticAnalysis }}
+        runPREFast: false
+
+    - ${{ if eq(parameters.runStaticAnalysis, 'true') }}:
+      - template: AzurePipelinesTemplates\WindowsAppSDK-Build-Stage.yml@self
+        parameters:
+          SignOutput: false
+          runApiScan: false
+          runPREFast: true
 
     - template: AzurePipelinesTemplates\WindowsAppSDK-PackTransportPackage-Stage.yml@self
       parameters: