docs: update framework star counts to current values#329
docs: update framework star counts to current values#329imran-siddique merged 10 commits intomicrosoft:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add EU AI Act, Colorado AI Act, and GPAI obligations timeline with AGT coverage mapping. Reference Microsoft Purview DSPM for AI as complementary data governance layer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Scorecard API rejects workflows with write permissions at the workflow level. id-token: write and security-events: write must be scoped to the job level only. Restores permissions: read-all at workflow level while keeping job-level write permissions intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ft#324) Add Google-style docstrings with Args, Returns, Raises, Attributes, and Example sections to MCPMessageType, MCPAdapter, and MCPServer classes. Also enhances docstrings for key methods including handle_message, _handle_tools_call, _handle_resources_read, and _map_tool_to_action. Fixes microsoft#316
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…s (dependency confusion) (microsoft#325) - Replace !pip install agent-os with !pip install -e ../.. in all 6 notebooks; agent-os is not on PyPI and installing it from PyPI is a dependency confusion vector - Replace zendesk-sdk/freshdesk-sdk with zenpy/freshdesk (the real published SDKs) in customer-service/requirements.txt - Remove hashlib-compat from healthcare-hipaa/requirements.txt; hashlib is stdlib and hashlib-compat is not a real PyPI package
…stall agent-os with agent-os-kernel Replace all remaining instances of `pip install agent-os` (unregistered on PyPI) with `pip install agent-os-kernel` (the actual package) across docs, examples, TypeScript extensions, CLI source, tests, and SVG assets. Also fixes `pip install emk` references to point to `agent-os-kernel[full]` since emk is a submodule, not a standalone PyPI package. Completes the fix started in PR microsoft#325 which only covered notebooks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dify 65K→133K, AutoGen 42K→55K, CrewAI 28K→46K, Semantic Kernel 24K→27K, LangGraph 24K→27K, Haystack 22K→24K, Agent Framework 7.6K→8K. Added star counts for OpenAI Agents SDK (20K) and Google ADK (18K). Sorted by stars descending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🤖 AI Agent: breaking-change-detector🔍 API Compatibility ReportSummaryThis pull request primarily updates documentation and introduces changes to package naming conventions (e.g., Findings
Migration Guide
Conclusion✅ No breaking changes were found in the public API. Downstream users should update their installation commands to reflect the new package name ( |
🤖 AI Agent: test-generatorThe provided pull request primarily involves documentation updates, configuration changes, and some minor code modifications. It does not directly modify the file |
There was a problem hiding this comment.
🤖 AI Agent: code-reviewer
Pull Request Review: docs: update framework star counts to current values
Summary
This pull request primarily updates documentation to reflect current star counts for various frameworks and introduces changes to package naming conventions (e.g., agent-os → agent-os-kernel). Additionally, it includes new CI workflows for link checking and modifies the OpenSSF Scorecard workflow permissions. Below is a detailed review of the changes.
🔴 CRITICAL
1. Potential Sandbox Escape in MCPAdapter
The MCPAdapter.handle_message method processes incoming JSON-RPC messages and applies governance checks. However, the governance logic is not fully visible in the provided diff. If the governance checks are improperly implemented or bypassed, this could lead to a sandbox escape or unauthorized actions by agents.
Actionable Recommendation:
- Ensure that the governance checks in
handle_messageare robust and comprehensive. Specifically:- Validate all incoming
methodandparamsfields against a whitelist. - Ensure that unknown tools or resources are denied by default.
- Implement strict type validation for
paramsusing Pydantic models. - Add unit tests to simulate edge cases, such as malformed JSON-RPC requests or attempts to bypass governance.
- Validate all incoming
2. Insecure Defaults in MCPAdapter
The MCPAdapter class appears to allow optional callbacks (on_block) and custom mappings (tool_mapping). If these are not properly validated, they could introduce vulnerabilities, such as allowing unauthorized tools or operations.
Actionable Recommendation:
- Validate
tool_mappingagainst a strict schema before merging it withDEFAULT_MCP_MAPPING. - Ensure that the
on_blockcallback cannot be exploited to leak sensitive information or bypass governance.
🟡 WARNING
1. Breaking Change: Package Renaming
The renaming of agent-os to agent-os-kernel is a breaking change for users who rely on the previous package name. This affects installation commands, documentation, and CI/CD workflows.
Actionable Recommendation:
- Provide clear migration instructions in the release notes.
- Consider aliasing the old package name (
agent-os) to the new one (agent-os-kernel) for backward compatibility, if feasible.
2. Workflow Permissions Update
The OpenSSF Scorecard workflow changes permissions from specific write scopes (security-events, id-token, etc.) to read-all. While this aligns with best practices for workflow-level permissions, it may inadvertently restrict functionality if job-level permissions are not properly configured.
Actionable Recommendation:
- Verify that job-level permissions are correctly scoped to allow necessary write operations (e.g.,
security-events).
💡 SUGGESTIONS
1. Link Checker Configuration
The new link-check.yml workflow uses lychee to check Markdown links. While this is a useful addition, the configuration excludes several domains (e.g., pypi.org, npmjs.com) due to rate-limiting issues.
Actionable Recommendation:
- Consider implementing retries with exponential backoff for excluded domains instead of outright exclusion.
- Periodically review the exclusion list to ensure it remains relevant.
2. Documentation Enhancements
The updated documentation includes regulatory alignment for the EU AI Act and Colorado AI Act. While this is valuable, it could benefit from additional details, such as links to official regulatory texts and examples of how the toolkit meets specific requirements.
Actionable Recommendation:
- Expand the "Regulatory Alignment" section with links to official documentation and practical examples.
3. Type Safety and Validation
The MCPAdapter class could benefit from stricter type safety and validation using Pydantic models for incoming JSON-RPC messages.
Actionable Recommendation:
- Define Pydantic models for MCP message types and validate incoming
messageobjects against these models inhandle_message.
4. Testing Coverage
The diff does not include updates to test cases for the renamed package (agent-os-kernel) or the MCP governance logic.
Actionable Recommendation:
- Add tests to ensure the renamed package is correctly referenced across all examples and CI/CD workflows.
- Simulate edge cases for MCP governance in unit tests.
5. Dependency Cleanup
The requirements.txt files contain references to non-existent or redundant packages (e.g., hashlib-compat).
Actionable Recommendation:
- Remove invalid dependencies and provide comments clarifying alternatives (e.g.,
hashlibis part of Python's standard library).
Final Assessment
Security
- 🔴 CRITICAL: Sandbox escape and insecure defaults in
MCPAdapter. - 🔴 CRITICAL: Governance logic in
handle_messageneeds thorough review.
Breaking Changes
- 🟡 WARNING: Package renaming (
agent-os→agent-os-kernel) impacts backward compatibility.
Improvements
- 💡 SUGGESTION: Enhance documentation, improve type safety, and update tests.
Recommendation
- Address critical security issues in
MCPAdapterimmediately. - Provide migration guidance for the package rename.
- Expand testing coverage and documentation.
This pull request introduces valuable updates but requires further refinement to ensure security and backward compatibility.
🤖 AI Agent: docs-sync-checker📝 Documentation Sync ReportIssues Found
Suggestions
Additional Notes
Please address the identified issues and suggestions to ensure the documentation is fully in sync with the changes introduced in this PR. Let me know if you need further assistance! |
🤖 AI Agent: security-scannerSecurity Analysis of the Pull RequestThis pull request primarily involves documentation updates, dependency adjustments, and minor code refactoring. Below is the security analysis based on the specified criteria: 1. Prompt Injection Defense BypassRating: 🔵 LOW
2. Policy Engine CircumventionRating: 🔵 LOW
3. Trust Chain WeaknessesRating: 🔵 LOW
4. Credential ExposureRating: 🔵 LOW
5. Sandbox EscapeRating: 🔵 LOW
6. Deserialization AttacksRating: 🔵 LOW
7. Race ConditionsRating: 🔵 LOW
8. Supply ChainRating: 🟠 HIGH
Additional Observations
Summary of Findings
Final Recommendation
|
Dify 65K→133K, AutoGen 42K→55K, CrewAI 28K→46K, Semantic Kernel 24K→27K, LangGraph 24K→27K, Haystack 22K→24K, Agent Framework 7.6K→8K. Added OpenAI Agents SDK (20K), Google ADK (18K). Sorted descending.