Skip to content

fix: upgrade ts-jest 29.1.0 to 29.2.5 for peer resolution bug#674

Merged
imran-siddique merged 1 commit intomicrosoft:mainfrom
imran-siddique:fix/ts-jest-peer-dep
Apr 1, 2026
Merged

fix: upgrade ts-jest 29.1.0 to 29.2.5 for peer resolution bug#674
imran-siddique merged 1 commit intomicrosoft:mainfrom
imran-siddique:fix/ts-jest-peer-dep

Conversation

@imran-siddique
Copy link
Copy Markdown
Member

ts-jest 29.1.0 has a peer dep resolution bug causing typescript to show as undefined during npm install. Upgrading to 29.2.5 fixes the ERESOLVE error in agentmesh-sdk.

ts-jest 29.1.0 has a peer dep resolution bug causing typescript to resolve
as undefined during npm install. Upgrading to 29.2.5 fixes ERESOLVE error.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@imran-siddique imran-siddique merged commit e801ab6 into microsoft:main Apr 1, 2026
18 of 19 checks passed
@github-actions github-actions bot added the size/XS Extra small PR (< 10 lines) label Apr 1, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Agent: code-reviewer

Review Feedback

🔴 CRITICAL

No critical issues identified in this pull request. The change is limited to upgrading a development dependency (ts-jest) and does not directly impact the runtime behavior or security of the Python library.


🟡 WARNING

No breaking changes identified. The upgrade from ts-jest 29.1.0 to 29.2.5 is a patch-level update and should not introduce backward compatibility issues. However, ensure that the updated version is tested thoroughly in your CI pipeline to confirm compatibility with your existing TypeScript and Jest configurations.


💡 SUGGESTION

  1. Add a Changelog Entry:
    Since this change addresses a specific bug (peer dependency resolution issue), it would be helpful to document this in the changelog for the agent-mesh-sdk package. This will provide clarity to developers about why the dependency was updated.

    Example:

    ### Fixed
    - Upgraded `ts-jest` from 29.1.0 to 29.2.5 to resolve a peer dependency issue with TypeScript.
    
  2. Lockfile Update:
    Ensure that the package-lock.json or yarn.lock file is updated and committed alongside this change. This ensures that the dependency tree is consistent across environments.

  3. Test Coverage:
    While this is a development dependency, it is critical to verify that the test suite runs successfully with the updated ts-jest version. Ensure that the CI pipeline includes a step to run all tests for the agent-mesh-sdk package.

  4. Dependency Audit:
    Consider running a dependency audit (e.g., npm audit or yarn audit) after upgrading ts-jest to ensure no new vulnerabilities are introduced by this change.


Summary

This pull request is a straightforward upgrade of a development dependency (ts-jest) to address a specific bug. While no critical or breaking issues are identified, it is recommended to:

  • Document the change in the changelog.
  • Update the lockfile.
  • Verify test coverage and CI pipeline compatibility.
  • Perform a dependency audit to ensure no new vulnerabilities are introduced.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

🤖 AI Agent: security-scanner — Security Analysis of the Pull Request

Security Analysis of the Pull Request

This pull request updates the ts-jest dependency from version 29.1.0 to 29.2.5 in the agent-mesh SDK's package.json. The stated purpose is to resolve a peer dependency issue with TypeScript during npm install.

1. Prompt Injection Defense Bypass

  • Assessment: No direct impact. This change does not modify any code related to prompt injection defenses or input sanitization.
  • Rating: 🔵 LOW

2. Policy Engine Circumvention

  • Assessment: No direct impact. The change is limited to a development dependency (ts-jest) and does not affect runtime policy enforcement or logic.
  • Rating: 🔵 LOW

3. Trust Chain Weaknesses

  • Assessment: No direct impact. The change does not involve any cryptographic operations, certificate validation, or trust chain mechanisms.
  • Rating: 🔵 LOW

4. Credential Exposure

  • Assessment: No direct impact. The change does not introduce any new logging, error handling, or debug output that could expose credentials.
  • Rating: 🔵 LOW

5. Sandbox Escape

  • Assessment: No direct impact. The change does not modify any sandboxing, containerization, or process isolation mechanisms.
  • Rating: 🔵 LOW

6. Deserialization Attacks

  • Assessment: No direct impact. The change does not involve deserialization or loading of untrusted data.
  • Rating: 🔵 LOW

7. Race Conditions

  • Assessment: No direct impact. The change does not involve concurrent operations or time-of-check-to-time-of-use (TOCTOU) vulnerabilities.
  • Rating: 🔵 LOW

8. Supply Chain

  • Assessment: Potential Risk. Upgrading ts-jest to a newer version introduces a supply chain consideration. While ts-jest is a widely used library, any dependency upgrade requires verification to ensure the new version is secure and does not introduce malicious code or vulnerabilities.
  • Rating: 🟡 MEDIUM

Attack Vector: If the new version of ts-jest (29.2.5) were compromised or introduced a vulnerability, it could potentially impact the development environment or test execution. While this is less critical than runtime dependencies, it could still lead to issues such as malicious code execution during testing or CI/CD pipeline compromise.

Suggested Fix:

  • Verify the integrity of the ts-jest package version 29.2.5 by checking its hash against a trusted source (e.g., npm's registry or the package's GitHub repository).
  • Review the changelog and commits between 29.1.0 and 29.2.5 to ensure no suspicious or breaking changes were introduced.
  • Use a lockfile (package-lock.json or yarn.lock) to pin the exact version of ts-jest and its transitive dependencies.

Overall Assessment

This pull request is low risk in terms of runtime security impact, as it only affects a development dependency (ts-jest). However, there is a medium-level supply chain risk associated with upgrading dependencies. Proper due diligence should be performed to ensure the new version of ts-jest is secure and trustworthy.

Recommendation

  • Approve the pull request after verifying the integrity and security of the ts-jest version 29.2.5.
  • Ensure that dependency upgrades are accompanied by a review of the changelog and any associated security advisories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR (< 10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant