Skip to content

Conversation

@JiahangXu
Copy link

Add a trace_agg_mode option to control whether the trace aggregation is performed per transition or per trajectory (by adding response mask for multi-turn). Default remains 'transition' for backward compatibility.

@JiahangXu JiahangXu requested review from SiyunZhao and Copilot October 9, 2025 14:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a trace_agg_mode configuration parameter to support both "transition" and "trajectory" level trace aggregation, with "transition" as the default for backward compatibility.

  • Introduces a trace_agg_mode parameter that controls aggregation behavior
  • Implements trajectory-level aggregation with response masking for multi-turn conversations
  • Adds configuration option to the YAML config file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
agentlightning/verl/trainer.py Passes trace_agg_mode config to daemon and adds debugging breakpoint
agentlightning/verl/daemon.py Implements trajectory aggregation logic and response mask generation
agentlightning/verl/config.yaml Adds trace_agg_mode configuration option with default value

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants