Skip to content

fix japanese translation #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix japanese translation #215

merged 1 commit into from
Jun 11, 2025

Conversation

leestott
Copy link
Contributor

Fix Japanese translation

Removing all files for retranslation.

@Copilot Copilot AI review requested due to automatic review settings June 10, 2025 17:01
Copy link
Contributor

👋 Thanks for contributing @leestott! We will review the pull request and get back to you soon.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all existing Japanese translation files to prepare for a full retranslation.

  • Deletes the translations/ja directory’s contents across multiple lessons and sample guides.
  • Clears out code samples, README files, and solution content under Japanese locale.
  • Enables a fresh retranslation workflow by wiping out old files.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
translations/ja/CODE_OF_CONDUCT.md Entire file removed to reset translation.
translations/ja/11-mcp/code_samples/... All Japanese code samples for MCP removed.
translations/ja/11-mcp/README.md Japanese lesson overview removed.
translations/ja/10-ai-agents-production/... Japanese production lesson removed.
translations/ja/08-multi-agent/... Japanese multi-agent solution and quiz removed.
translations/ja/07-planning-design/... Japanese planning lesson removed.
translations/ja/06-building-trustworthy-agents/... Japanese trustworthy agents lesson removed.
translations/ja/05-agentic-rag/... Japanese agentic RAG content removed.
translations/ja/04-tool-use/... Japanese tool use lesson removed.
translations/ja/03-agentic-design-patterns/... Japanese design patterns lesson removed.
translations/ja/02-explore-agentic-frameworks/... Japanese framework exploration removed.
translations/ja/01-intro-to-ai-agents/... Japanese intro lesson removed.
translations/ja/00-course-setup/... Japanese course setup content removed.
translations/ja/00-course-setup/AzureSearch.md Japanese Azure Search setup removed.
Comments suppressed due to low confidence (1)

translations/ja/CODE_OF_CONDUCT.md:1

  • Removing all Japanese translation files at once may break localization pipelines or user documentation routes; ensure build scripts and navigation links are updated or replaced with placeholders to avoid broken references.
-   -# Microsoft Open Source Code of Conduct

@leestott
Copy link
Contributor Author

this will be fixed in #215

@leestott leestott closed this Jun 10, 2025
@leestott leestott reopened this Jun 10, 2025
@skytin1004
Copy link
Contributor

Hi @leestott,

Thanks for the fix. I noticed that some of the removals were triggered by an edge case where the translation output caused an error during API handling, something likely not fixable by simply regenerating the translations.

My suggestion is to go ahead and merge these PRs (#209, #207, #206, #202) as they are, and I'll continue investigating the issue within Co-op Translator to improve handling of such edge cases going forward.

Happy to follow up with a more robust patch once I've identified the root cause. Let me know what you think!

@koreyspace koreyspace merged commit 47dfa81 into main Jun 11, 2025
5 checks passed
@skytin1004
Copy link
Contributor

skytin1004 commented Jun 11, 2025

Hi @koreyspace,

Just to clarify, my earlier comment was intended to suggest keeping the contributed translations, rather than removing them and regenerating from scratch.

My suggestion was to close this PR and instead merge the others I referenced (#209, #207, #206, #202), which preserved the translated content.

That said, I understand the PR has already been merged, and I'll make sure to address this properly in the upcoming Co-op Translator improvements.

I also reviewed the Japanese translations myself, and I noticed that a few of the issues wouldn't be resolved even by simply regenerating the content using Co-op Translator. In fact, some of them require manual refinement or improvement within the original source content itself.

That's why I personally feel that contributions from people working on improving translations manually are worth preserving, when possible. Just wanted to ask your thoughts on this approach.

Of course, I fully understand if the current decision stands.
I just wanted to check whether reverting this PR and merging the previously contributed translations (#209, #207, #206, #202) might still be an option.

Really appreciate your time and the quick response. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants