[Test Improver] test: add unit tests for MCPIntegrator (0% -> ~75%)

[danielmeppiel]

🤖 Test Improver — automated AI assistant

Goal and Rationale

MCPIntegrator (src/apm_cli/integration/mcp_integrator.py, 1395 lines) is a large, high-risk orchestrator with zero dedicated tests. It owns MCP dependency resolution, deduplication, server-info building, drift detection, runtime detection, lockfile persistence, and stale cleanup across five runtimes (VS Code, Copilot, Codex, Cursor, OpenCode).

Bugs here could silently corrupt MCP configuration files across all runtimes. This PR adds focused unit tests for every pure-logic method.

Approach

Tests target the methods that can be verified without live runtimes or network:

Class	Methods Covered
TestIsVscodeAvailable	_is_vscode_available() — PATH + dir detection
TestDeduplicate	deduplicate() — first-wins, dict/str/nameless entries, ordering
TestGetServerNames	get_server_names() — dep objects, strings, mixed
TestGetServerConfigs	get_server_configs() — serialization, plain-string fallback
TestAppendDrifted	_append_drifted_to_install_list() — sorted append, dedup
TestDetectMcpConfigDrift	_detect_mcp_config_drift() — changed/unchanged/new configs
TestDetectRuntimes	_detect_runtimes() — word-boundary regex, multi-runtime
TestBuildSelfDefinedInfo	_build_self_defined_info() — stdio, http/sse, env, args, headers, tools
TestApplyOverlay	_apply_overlay() — transport, package filter, headers, args (list+dict), tools, warning
TestUpdateLockfile	update_lockfile() — temp file writes, sorted servers, empty clear
TestRemoveStaleVscode	remove_stale() — server removal, short-name matching, runtime targeting
TestRemoveStaleCopilot	remove_stale() — copilot config cleanup
TestCollectTransitive	collect_transitive() — missing/empty dir edge cases

Coverage Impact

Metric	Before	After
Test count	3,748	3,818
New tests	—	70
mcp_integrator.py coverage	~0%	~75%

Test Status

3818 passed in 14.33s

All 70 new tests pass. Full unit suite passes with no regressions.

Reproducibility

# Run new tests only
uv run pytest tests/unit/integration/test_mcp_integrator.py -v

# Run full unit suite
uv run pytest tests/unit tests/test_console.py -x -q

Generated by Daily Test Improver · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/daily-test-improver.md@b87234850bf9664d198f28a02df0f937d0447295