Add tests for custom tools (used to generate API docs)#578
Merged
IEvangelist merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
61e19d3 to
1d36760
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1d36760 to
f7ea6fc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces and preserves the tool generator test projects and their CI wiring on a separate branch, after they were removed from release/13.2, so the test additions aren’t lost.
Changes:
- Adds new xUnit test projects for
PackageJsonGeneratorandAtsJsonGenerator, including helper tests and temporary-assembly/test-data scaffolding. - Introduces a dedicated GitHub Actions workflow to run these tool generator tests and publish TRX/binlog artifacts with a step summary.
- Wires the new test projects into the repo solution and adjusts
.dockerignoreto exclude tests from Docker build context.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/scripts/Write-TestSummary.ps1 | New PowerShell helper to aggregate TRX results into a GitHub Step Summary (with optional artifact link). |
| tests/PackageJsonGenerator.Tests/PackageJsonGeneratorTests.cs | Adds coverage for package.json metadata output, enum sealing behavior, XML docs list handling, and LF normalization/no-op rewrites. |
| tests/PackageJsonGenerator.Tests/PackageJsonGeneratorHelperTests.cs | Adds unit tests for helper methods like raw GitHub URL building and line parsing. |
| tests/PackageJsonGenerator.Tests/PackageJsonGenerator.Tests.csproj | New test project targeting net10.0 and referencing the PackageJsonGenerator tool project. |
| tests/PackageJsonGenerator.Tests/GlobalUsings.cs | Adds global xUnit using for the test project. |
| tests/AtsJsonGenerator.Tests/AtsTransformerHelperTests.cs | Adds targeted tests for ATS transformer helper formatting/normalization behavior. |
| tests/AtsJsonGenerator.Tests/AtsJsonGeneratorTests.cs | Adds end-to-end-ish TransformFile tests including base-model dedupe and LF normalization/no-op rewrites. |
| tests/AtsJsonGenerator.Tests/AtsJsonGenerator.Tests.csproj | New test project targeting net10.0 and referencing the AtsJsonGenerator tool project. |
| tests/AtsJsonGenerator.Tests/GlobalUsings.cs | Adds global xUnit using for the test project. |
| Aspire.Dev.slnx | Includes the new test projects in the repo solution structure. |
| .github/workflows/tools-tests.yml | Adds a CI workflow to restore/run both test projects, upload results, and generate a summary. |
| .dockerignore | Excludes test content from Docker build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eerhardt
reviewed
Apr 6, 2026
| @@ -0,0 +1,164 @@ | |||
| param( | |||
Member
There was a problem hiding this comment.
I wish there was a built-in task for this. Seems odd that we need to implement it ourselves.
eerhardt
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR preserves the tool generator test additions separately from
release/13.2after the direct cleanup commit that removed them from the release branch.Included here
tests/AtsJsonGenerator.Teststests/PackageJsonGenerator.Tests.github/workflows/tools-tests.ymlNotes
release/13.2was updated directly to remove these tests.release/13.2unless you intentionally want to reintroduce the tests there or retarget the PR.Validation
dotnet test tests/PackageJsonGenerator.Tests/PackageJsonGenerator.Tests.csproj --configuration Release --nologodotnet test tests/AtsJsonGenerator.Tests/AtsJsonGenerator.Tests.csproj --configuration Release --nologo