Optimize test_delete_tmp_files by using single Docker executor#7624
Open
Maratik555 wants to merge 2 commits intomicrosoft:mainfrom
Open
Optimize test_delete_tmp_files by using single Docker executor#7624Maratik555 wants to merge 2 commits intomicrosoft:mainfrom
Maratik555 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Add a manually curated llms.txt file following the llms.txt standard (https://llmstxt.org/) that provides a structured index of key documentation pages for LLM consumption. Covers AutoGen Studio, AgentChat, Core, Extensions, and API Reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #6376
test_delete_tmp_fileswas creating twoDockerCommandLineCodeExecutorinstances (one fordelete_tmp_files=False, one fordelete_tmp_files=True), each requiring a Docker container startup (~10s each).This PR reduces Docker container creation from 2 to 1 by merging all test scenarios into a single executor with
delete_tmp_files=True. Thedelete_tmp_files=False(default) case is covered implicitly by other tests using the module-scoped executor fixture.Impact
test_docker_commandline_code_executor.pyruntime