feat(render): add WithSkipLookaside preparer option#61
Open
dmcilvaney wants to merge 1 commit intomicrosoft:mainfrom
Open
feat(render): add WithSkipLookaside preparer option#61dmcilvaney wants to merge 1 commit intomicrosoft:mainfrom
dmcilvaney wants to merge 1 commit intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “skip lookaside” option to the source preparation pipeline so rendering workflows can avoid expensive lookaside/tarball downloads while still fetching git-tracked spec + sidecar files.
Changes:
- Add
WithSkipLookaside()as aPreparerOptionand plumb it intoPrepareSources()to skipSourceManager.FetchFiles. - Add
WithSkipLookaside()as aFetchComponentOptionand wire it throughSourceManagerfor local components and Fedora upstream fetching to skip lookaside extraction. - Add unit tests validating that lookaside extraction/download steps are skipped when the option is enabled.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/providers/sourceproviders/sourcemanager.go | Adds SkipLookaside fetch option and skips lookaside download for local components. |
| internal/providers/sourceproviders/fedorasourceprovider.go | Skips ExtractSourcesFromRepo when SkipLookaside is set during upstream repo processing. |
| internal/providers/sourceproviders/fedorasourceprovider_test.go | Adds test ensuring ExtractSourcesFromRepo is not invoked when skip-lookaside is enabled. |
| internal/app/azldev/core/sources/sourceprep.go | Adds preparer-level WithSkipLookaside and skips FetchFiles, while passing skip option into FetchComponent. |
| internal/app/azldev/core/sources/sourceprep_test.go | Adds tests for WithSkipLookaside behavior around FetchFiles/FetchComponent calls. |
Add WithSkipLookaside() PreparerOption that skips lookaside cache downloads during source preparation. This avoids expensive tarball downloads when only spec + sidecar files are needed (e.g., for rendering). Wired through three paths: - sourceprep: skips FetchFiles call entirely - fedorasourceprovider: skips ExtractSourcesFromRepo in processClonedRepo - sourcemanager: skips downloadLookasideSources for local components Git-tracked files (spec, patches, scripts) are still fetched from the upstream clone.
dmcilvaney
force-pushed
the
damcilva/skip-lookaside
branch
from
870fa40 to
ada0d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WithSkipLookaside() PreparerOption that skips lookaside cache downloads during source preparation. This avoids expensive tarball downloads when only spec + sidecar files are needed (e.g., for rendering).
Wired through three paths:
Git-tracked files (spec, patches, scripts) are still fetched from the upstream clone.