Container Node selection | L0 tests #5450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner support - Added CanHandleInContainer methods to Node24Strategy, Node20Strategy, and Node16Strategy for container-specific logic - Updated NodeVersionOrchestrator with dual selection paths: SelectNodeVersionForHostAsync() and SelectNodeVersionForContainer() - Integrated container support in ContainerOperationProvider with proper node path detection - Removed node --version dependency for container command in ContainerOperationProvider. - Enhanced NodeRunnerInfo with ContainerDefaultNode support for cross-platform scenarios - Restructured test infrastructure for container tests with comprehensive container test scenarios and improved organization
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| private BaseNodeHandlerData GetJobContainerHandlerData(IExecutionContext executionContext, ContainerInfo container) | ||
| { | ||
| // Custom node takes highest priority | ||
| if (!string.IsNullOrEmpty(container.CustomNodePath)) |
Contributor
There was a problem hiding this comment.
if label in dockerfile considered as customnode?
Contributor
Author
There was a problem hiding this comment.
Yes, label is considered as custom node
| ), | ||
|
|
||
| new TestScenario( | ||
| name: "Container_GlobalNode24Knob_OverridesContainerDefaults", |
Contributor
There was a problem hiding this comment.
please add a test case if knobs for node24/20 is enabled still custom node will be used
Contributor
Author
There was a problem hiding this comment.
This is updated.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| // Skip container tests on macOS since they always use cross-platform logic | ||
| // This is expected behavior - macOS agent binaries cannot run in typical Linux containers | ||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) |
Contributor
There was a problem hiding this comment.
Skip macOS logic can we move it to start of this method like this?
[Trait("SkipOn", "darwin")]
This approach skips the entire method for macOS, and I believe this aligns with the pattern we follow in the agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses Azure Pipelines Agent container node selection process and implements a comprehensive strategy pattern for Node.js version selection in container environments.
AB#2343104
AB#2343431
AB#2345319
AB#2345320
AB#2345321
Description
SelectNodeVersionForHostAsync()andSelectNodeVersionForContainer()ContainerOperationProviderwith proper node path detectionContainerOperationProvider.Risk Assessment (Low / Medium / High)
Medium Risk - This change affects the core node selection logic for container execution. However, risk is mitigated by:
AGENT_USE_NODE_STRATEGY)Unit Tests Added or Updated (Yes / No)
Additional Testing Performed
List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).
Change Behind Feature Flag (Yes / No)
Yes - The change can be controlled via existing feature mechanisms:
AGENT_USE_NODE_STRATEGYcontrols strategy vs legacy behaviorTech Design / Approach
Documentation Changes Required (Yes/No)
Indicate whether related documentation needs to be updated.
Logging Added/Updated (Yes/No)
Telemetry Added/Updated (Yes/No)
Rollback Scenario and Process (Yes/No)
Dependency Impact Assessed and Regression Tested (Yes/No)