Skip to content

Commit

Permalink
NuGetAuthenticateV1: Add WIF Service Connection Support (#20299)
Browse files Browse the repository at this point in the history
* Adding task changes

* Adding TaskJsonOverride to support new input

* Adding generated wif

* Updating logic in main, adding locstrings

* task bump && bump common package

* removing groupname from task json

* adding url check and spelling

* Removing duplicate error checking, try parse url

* Improved feed url check

* Adding telemetry for federatedFeedAuthCount

* bumping azure-pipelines-task-lib

* UX improvements

* merge conflict fix

* Bump Task Version

* run --write-updates

* Fix Url Validation and PR Comments

* --write-updates

* bump common task

* --write-updates

* --write-updates

* write updates

* add input validation

* write updates

* build validation passes locally

* revert en-us changes

* Add en-us strings

* fix strings part 2

* write updates

---------

Co-authored-by: Alex Torres <[email protected]>
Co-authored-by: Alex Torres <[email protected]>
  • Loading branch information
3 people authored Aug 19, 2024
1 parent 6623ded commit e0693ba
Show file tree
Hide file tree
Showing 52 changed files with 2,698 additions and 658 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,14 @@
"loc.input.label.nuGetServiceConnections": "Service connection credentials for feeds outside this organization",
"loc.input.help.nuGetServiceConnections": "Comma-separated list of NuGet service connection names for feeds outside this organization/collection. For feeds in this organization/collection, leave this blank; the build’s credentials are used automatically.",
"loc.input.label.forceReinstallCredentialProvider": "Reinstall the credential provider even if already installed",
"loc.input.help.forceReinstallCredentialProvider": "If the credential provider is already installed in the user profile, determines if it is overwritten with the task-provided credential provider. This may upgrade (or potentially downgrade) the credential provider."
"loc.input.help.forceReinstallCredentialProvider": "If the credential provider is already installed in the user profile, determines if it is overwritten with the task-provided credential provider. This may upgrade (or potentially downgrade) the credential provider.",
"loc.input.help.feedUrl": "If this is set, workloadIdentityServiceConnection is required. All other inputs are ignored. Not compatible with nuGetServiceConnections. Feed Url should be in the NuGet service index format, e.g. https://pkgs.dev.azure.com/{ORG_NAME}/{PROJECT}/_packaging/{FEED_NAME}/nuget/v3/index.json/",
"loc.input.label.feedUrl": "Azure Artifacts URL",
"loc.input.help.workloadIdentityServiceConnection": "If this is set, feedUrl is required. All other inputs are ignored.",
"loc.input.label.workloadIdentityServiceConnection": "'Entra Workload ID-backed Azure DevOps user' Service Connection",
"loc.messages.Error_ServiceConnectionExists": "An existing service connection already exists for the endpoint",
"loc.messages.Error_MissingFeedUrlOrServiceConnection": "Both feedUrl and workloadIdentityServiceConnection must be set together.",
"loc.messages.Info_AddingFederatedFeedAuth": "Unable to get federated credentials from service connection",
"loc.messages.Info_SuccessAddingFederatedFeedAuth": "Adding auth information from service connection %s for feed %s",
"loc.messages.FailedToGetServiceConnectionAuth": "Successfully added auth for feed %s."
}
16 changes: 8 additions & 8 deletions Tasks/NuGetAuthenticateV1/_buildConfigs/Node20/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Tasks/NuGetAuthenticateV1/_buildConfigs/Node20/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
},
"homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
"dependencies": {
"azure-pipelines-tasks-artifacts-common": "^2.244.0",
"azure-pipelines-task-lib": "^4.0.0-preview",
"@types/node": "^20.3.1"
"@types/node": "^20.3.1",
"azure-pipelines-task-lib": "^4.13.0",
"azure-pipelines-tasks-artifacts-common": "^2.244.3"
},
"devDependencies": {
"typescript": "5.1.6"
Expand Down
Loading

0 comments on commit e0693ba

Please sign in to comment.