Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 23, 2025

Problem

Both GitHubReleaseV0 and GitHubReleaseV1 tasks had identical ChangeLog.ts implementations, which was incorrect. The V0 task is marked as deprecated and should provide simpler functionality, while V1 is the current version with enhanced features.

Changes

This PR creates the proper functional distinction between the two versions:

GitHubReleaseV0 (Deprecated Version)

  • Removed auto-generated text functionality from changelog output
  • Removed methods: _getAutoGeneratedText(), _getAutoGeneratedUrl()
  • Simplified _generateChangeLog() method to not append auto-generated links
  • Removed related constants: _buildUrlFormat, _autoGeneratedTextFormat
  • Updated test expectations to match the simpler behavior

GitHubReleaseV1 (Current Version)

  • Maintains full auto-generated text functionality
  • Continues to append "This list of changes was auto generated" to changelogs
  • No changes to existing functionality

Example Output Difference

Before (both versions identical):

## What's Changed:

* abc123 Fix issue #42
* def456 Add new feature

This list of changes was [auto generated](https://dev.azure.com/org/project/_build/results?buildId=123).

After V0 (simplified):

## What's Changed:

* abc123 Fix issue #42  
* def456 Add new feature

After V1 (enhanced):

## What's Changed:

* abc123 Fix issue #42
* def456 Add new feature

This list of changes was [auto generated](https://dev.azure.com/org/project/_build/results?buildId=123).

Benefits

  1. Proper Version Distinction: V0 is now truly the simpler deprecated version, V1 is the enhanced current version
  2. Backward Compatibility: Existing V0 users won't see unexpected auto-generated links appear
  3. Clear Migration Path: Users upgrading from V0 to V1 will gain the auto-generated functionality
  4. Consistent with Task Definitions: Aligns with V0 being marked as deprecated: true and V1 being the current version

Files Changed

  • Tasks/GitHubReleaseV0/operations/ChangeLog.ts - Removed auto-generated functionality
  • Tasks/GitHubReleaseV0/Tests/ChangeLogL0Tests.ts - Updated test expectations
  • Tasks/GitHubReleaseV1/operations/ChangeLog.ts - No changes (maintains existing functionality)
  • Tasks/GitHubReleaseV1/Tests/ChangeLogL0Tests.ts - No changes (maintains existing expectations)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 03nvsblobprodwcus014.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 055vsblobprodwcus02.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 1g1vsblobprodwcus01.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 3eavsblobprodwcus03.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 3zgvsblobprodwcus024.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 40qvsblobprodwcus022.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 4fdvsblobprodwcus012.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 5tbvsblobprodwcus06.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 61cvsblobprodwcus010.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 73dvsblobprodwcus07.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 8usvsblobprodwcus011.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • 9owvsblobprodwcus020.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • arpvsblobprodwcus017.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • crcvsblobprodwcus021.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • fslvsblobprodwcus015.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • grnvsblobprodwcus04.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • k92vsblobprodwcus08.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • mnzvsblobprodwcus05.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • pl8vsblobprodwcus09.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • uubvsblobprodwcus018.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • vwmvsblobprodwcus016.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • x4wvsblobprodwcus013.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • xg1vsblobprodwcus019.vsblob.vsassets.io
    • Triggering command: npm install (dns block)
  • xlkvsblobprodwcus023.vsblob.vsassets.io
    • Triggering command: npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@KathanS KathanS closed this Sep 23, 2025
Copilot AI changed the title [WIP] See this PR Fix functional differences between GitHubReleaseV0 and GitHubReleaseV1 ChangeLog implementations Sep 23, 2025
Copilot AI requested a review from KathanS September 23, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants