Fix functional differences between GitHubReleaseV0 and GitHubReleaseV1 ChangeLog implementations #21338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Both
GitHubReleaseV0andGitHubReleaseV1tasks had identicalChangeLog.tsimplementations, which was incorrect. The V0 task is marked as deprecated and should provide simpler functionality, while V1 is the current version with enhanced features.Changes
This PR creates the proper functional distinction between the two versions:
GitHubReleaseV0 (Deprecated Version)
_getAutoGeneratedText(),_getAutoGeneratedUrl()_generateChangeLog()method to not append auto-generated links_buildUrlFormat,_autoGeneratedTextFormatGitHubReleaseV1 (Current Version)
Example Output Difference
Before (both versions identical):
After V0 (simplified):
After V1 (enhanced):
Benefits
deprecated: trueand V1 being the current versionFiles Changed
Tasks/GitHubReleaseV0/operations/ChangeLog.ts- Removed auto-generated functionalityTasks/GitHubReleaseV0/Tests/ChangeLogL0Tests.ts- Updated test expectationsTasks/GitHubReleaseV1/operations/ChangeLog.ts- No changes (maintains existing functionality)Tasks/GitHubReleaseV1/Tests/ChangeLogL0Tests.ts- No changes (maintains existing expectations)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
03nvsblobprodwcus014.vsblob.vsassets.ionpm install(dns block)055vsblobprodwcus02.vsblob.vsassets.ionpm install(dns block)1g1vsblobprodwcus01.vsblob.vsassets.ionpm install(dns block)3eavsblobprodwcus03.vsblob.vsassets.ionpm install(dns block)3zgvsblobprodwcus024.vsblob.vsassets.ionpm install(dns block)40qvsblobprodwcus022.vsblob.vsassets.ionpm install(dns block)4fdvsblobprodwcus012.vsblob.vsassets.ionpm install(dns block)5tbvsblobprodwcus06.vsblob.vsassets.ionpm install(dns block)61cvsblobprodwcus010.vsblob.vsassets.ionpm install(dns block)73dvsblobprodwcus07.vsblob.vsassets.ionpm install(dns block)8usvsblobprodwcus011.vsblob.vsassets.ionpm install(dns block)9owvsblobprodwcus020.vsblob.vsassets.ionpm install(dns block)arpvsblobprodwcus017.vsblob.vsassets.ionpm install(dns block)crcvsblobprodwcus021.vsblob.vsassets.ionpm install(dns block)fslvsblobprodwcus015.vsblob.vsassets.ionpm install(dns block)grnvsblobprodwcus04.vsblob.vsassets.ionpm install(dns block)k92vsblobprodwcus08.vsblob.vsassets.ionpm install(dns block)mnzvsblobprodwcus05.vsblob.vsassets.ionpm install(dns block)pl8vsblobprodwcus09.vsblob.vsassets.ionpm install(dns block)uubvsblobprodwcus018.vsblob.vsassets.ionpm install(dns block)vwmvsblobprodwcus016.vsblob.vsassets.ionpm install(dns block)x4wvsblobprodwcus013.vsblob.vsassets.ionpm install(dns block)xg1vsblobprodwcus019.vsblob.vsassets.ionpm install(dns block)xlkvsblobprodwcus023.vsblob.vsassets.ionpm install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.