Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valkey to 3.0 #10579

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add Valkey to 3.0 #10579

merged 3 commits into from
Oct 1, 2024

Conversation

xordux
Copy link
Contributor

@xordux xordux commented Sep 30, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add Valkey to 3.0

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Local Build and installation
  • Pipeline build id: 649348

@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Oct 1, 2024
@xordux
Copy link
Contributor Author

xordux commented Oct 1, 2024

Buddy build installation is failing due to know libcrypto issue, I was able to install it in local Azure Linux 3.0:

image

@xordux xordux changed the title Rohit/valkey Add Valkey to 3.0 Oct 1, 2024
@xordux xordux marked this pull request as ready for review October 1, 2024 09:56
@xordux xordux requested a review from a team as a code owner October 1, 2024 09:56
%config(noreplace) %attr(0640, %{name}, %{name}) %{_sysconfdir}/valkey.conf

%changelog
* Mon Sep 30 2024 Rohit Rawat <[email protected]> - 8.0.0-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aewsome :)

@xordux xordux merged commit 1118da2 into 3.0-dev Oct 1, 2024
12 checks passed
@xordux xordux deleted the rohit/valkey branch October 1, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants