Removed duplicate user space packages from OOT kmod specs #14860
Conversation
microsoft-github-policy-service
bot
added
Packaging
3.0-dev
✅ PR Check PassedNo critical issues detected in spec file changes. 🤖 AI Analysis Summary:Brief Analysis: The changes primarily update the MOFED version (from 24.10-22 to 24.10-23) and adjust package dependencies and release numbers in multiple spec files, including fwctl-hwe-signed.spec. There are no explicit CVE patch directives referenced in this file. Critical Issues Found: Recommended Actions: 📋 For detailed analysis and recommendations, check the Azure DevOps pipeline logs. |
| %config(noreplace) %{_sysconfdir}/depmod.d/zz02-fwctl-*.conf | ||
|
|
||
| %changelog | ||
| * Fri Oct 10 2025 Pawel Winogrodzki <[email protected]> - 24.10-23 |
There was a problem hiding this comment.
I think the changelog number should include the release_suffix - 24.10-23_6.12.50.2-1
There was a problem hiding this comment.
Same comment goes for a few other packages below. The most recent changelog comments have this as well (at least since the hwe- variant of these SPECs were created)
|
|
||
| /bin/rm -rf %{buildroot}/opt/knem-%{version}/lib/modules || true | ||
| /bin/rm -rf %{buildroot}/opt/knem-%{version} | ||
| /bin/rm -rf %{buildroot}//etc/udev/rules.d |
| %global kernel_source() %{K_SRC} | ||
| %global kernel_release() %{KVERSION} | ||
| %global flavors_to_build default | ||
| %ifarch x86_64 # We create the module package only for the x86_64 kernel |
There was a problem hiding this comment.
I believe comments on lines with %ifarch cause warnings during the builds, so might be best to put them on the preceding line. (I realize this issue already exists in many of these specs, so this is just a suggestion)
3 participants
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Overview
Some of our specs building OOT kmods for
kernel-hwedefined packages with user space components, which were duplicates of already existing ones from specs building OOT kmods forkernelalong with the user space components. Since they are dependent on a kernel flavour, as long as they build against the lowest version of kernel in our repository (kernel), they are guaranteed to work on newer versions and flavours due to kernel's guarantees to keep user space APIs backwards compatible.The duplicates were removed to:
Changes details
mlnx-ofa_kernelfor a genericRequires: mlnx-ofa_kernel.mlnx-ofa_kernelis a user-space package and is thus not tied to any specific kernel version of flavour.BuildRequires: mlnx-ofa_kernel-hwe-source- OOT kmod specs having their kmods dependent on the one frommlnx-ofa_kernel-modulesneed themlnx-ofa_kernel(-<flavour>)-develfor the same version and flavour of the kernel as they are built but not the original sources. Also, thedevelsubpackage already contains the required sources.*-hwespecs.servicesubpackage from the OOT kmod subpackages inmlnx-ofa_kernel.spec, since the service components are living in user space and are not tied to a specific version or flavour of the kernel.mlnx-ofa_kernelbuild user space components for both supported architectures.Does this affect the toolchain?
No.
Test Methodology