workaround(vamp-plugin-sdk): fix dependency race in Makefile with a patch overlay#16234
workaround(vamp-plugin-sdk): fix dependency race in Makefile with a patch overlay#16234binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an Azure Linux component override for vamp-plugin-sdk to apply a Makefile fix that prevents a parallel-make dependency race when building static archives, delivered via a patch added to the component’s sources and referenced from the spec via a spec-search-replace workaround.
Changes:
- Add a new
vamp-plugin-sdk.comp.tomlwith overlays to inject a new patch reference into the spec and add the patch file to sources. - Add
makefile-libvamp-sdk-race-fix.patchto moveranlibsteps into the archive-producing targets to avoid link-time races undermake -j.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| base/comps/vamp-plugin-sdk/vamp-plugin-sdk.comp.toml | Introduces overlays to reference and ship a new patch (using spec-search-replace + file-add). |
| base/comps/vamp-plugin-sdk/makefile-libvamp-sdk-race-fix.patch | Patch adjusting Makefile.in recipes to eliminate ranlib/archive race in parallel builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
issue: when available, always use the actual upstream commit as generated from git format-patch
suggestion: please replace this patch file with vamp-plugins/vamp-plugin-sdk@da2d66f
…ch from upstream Investigating build logs of failed vamp-plugin-sdk builds showed a possible race in multiple targets which work on static version of vamp* libaries. The fix is to fix the recipes to force correct dependencies. A local build and more than one koji build with the changes succeeded. There is a bug in azldev patch which prevents a numbered patch being added when bare "patch" tag is present. As a workaround the new patch is added via a regexp replace overlay.
e816c92 to
56e15f6
Compare
Investigating build logs of failed vamp-plugin-sdk builds showed a possible race in multiple targets which work on static version of vamp* libaries. The fix is to fix the recipes to force correct dependencies. A local build and more than one koji build with the changes succeeded.
https://52.249.25.247/koji/taskinfo?taskID=656595
There is a bug in azldev patch which prevents a numbered patch being added when bare "patch" tag is present. As a workaround the new patch is added via a regexp replace overlay.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology