fix(rust): Fetch rust 1.94 from a later snapshot than the default 1.93#16244
fix(rust): Fetch rust 1.94 from a later snapshot than the default 1.93#16244binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
Rust build has a bootstrap stage on some architecture which demand some version of rust compiler be already available. For the version of rust package we have pinned, that version is 1.93. 1.93 is no longer available from Fed43 repo. To fix this we fetch from a later snapshot of rust which works on 1.94 version for bootstrap build.
There was a problem hiding this comment.
Pull request overview
Pins the rust component’s upstream spec source to a Fedora 43 snapshot so the bootstrap compiler requirements align with what’s still available in Fedora repos (moving from Rust 1.93-era bootstrap to a 1.94-era snapshot), and removes the now-customized component from the “no per-component modifications” list.
Changes:
- Add
base/comps/rust/rust.comp.tomlto pinrustto a Fedora 43 snapshot (2026-03-10T00:00:00-08:00). - Remove
[components.rust]frombase/comps/components.tomlsince it’s no longer “unmodified Fedora import”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| base/comps/rust/rust.comp.toml | Introduces a per-component snapshot pin for the upstream Rust spec to pick up the newer bootstrap expectations. |
| base/comps/components.toml | Removes rust from the unmodified component list to reflect the new customization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,4 @@ | |||
| [components.rust] | |||
| # Fedora repo does not have 1.93 which the spec gets pinned to. Snapshot from a | |||
| # later version to pickup a later version - 1.94, which is available. | |||
There was a problem hiding this comment.
The snapshot pin here is hard to validate/maintain without a concrete reference. Please add a short note (and ideally a URL) pointing to the Fedora rust f43 dist-git commit/NVR change that moved the bootstrap compiler requirement from 1.93 to 1.94, plus a TODO/criteria for when this snapshot pin can be removed (e.g., once the distro default snapshot/toolchain updates).
| # later version to pickup a later version - 1.94, which is available. | |
| # later version to pickup a later version - 1.94, which is available. | |
| # Reference: Fedora rust f43 dist-git raised the bootstrap compiler requirement | |
| # to 1.94 during the 1.94 toolchain rebase; see the f43 branch history: | |
| # https://src.fedoraproject.org/rpms/rust/commits/f43 | |
| # TODO: Drop this explicit snapshot pin once the default Fedora 43 rust | |
| # snapshot/toolchain tracked in azurelinux.distro.toml already requires a | |
| # bootstrap compiler >= 1.94, so this override no longer changes the effective | |
| # toolchain version. |
| @@ -0,0 +1,4 @@ | |||
| [components.rust] | |||
| # Fedora repo does not have 1.93 which the spec gets pinned to. Snapshot from a | |||
| # later version to pickup a later version - 1.94, which is available. | |||
There was a problem hiding this comment.
Typo/grammar in the comment: "to pickup" should be "to pick up".
| # later version to pickup a later version - 1.94, which is available. | |
| # later version to pick up a later version - 1.94, which is available. |
Rust build has a bootstrap stage on some architecture which demand some version of rust compiler be already available. For the version of rust package we have pinned, that version is 1.93. 1.93 is no longer available from Fed43 repo. To fix this we fetch from a later snapshot of rust which works on 1.94 version for bootstrap build.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology