Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify internal validation logic + don't check for change needed in bump command #1023

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ecraig12345
Copy link
Member

Previously validate() had an option allowFetching (default true) which was hiding the actual behavior. It was also not precise about which commands needed to validate dependencies or not. Update the options as follows:

  • checkChangeNeeded: check whether change files are needed (change, check)
  • allowMissingChangeFiles: used with above, but don't error on missing change files (change)
  • checkDependencies: perform an in-memory bump and validate that no package to be bumped (including dependents) have private dependencies (most commands but change). Previously in some cases, change would include this check, which just slows it down and isn't needed.

As a side effect of the confusing options, previously the bump command was checking for whether change files are needed, which was odd and probably an artifact of allowFetching defaulting to true, not intentional.

@ecraig12345 ecraig12345 merged commit 7447005 into master Nov 26, 2024
5 checks passed
@ecraig12345 ecraig12345 deleted the ecraig/validate-options branch November 26, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant