Clarify internal validation logic + don't check for change needed in bump command #1023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
validate()
had an optionallowFetching
(default true) which was hiding the actual behavior. It was also not precise about which commands needed to validate dependencies or not. Update the options as follows:checkChangeNeeded
: check whether change files are needed (change
,check
)allowMissingChangeFiles
: used with above, but don't error on missing change files (change
)checkDependencies
: perform an in-memory bump and validate that no package to be bumped (including dependents) have private dependencies (most commands butchange
). Previously in some cases,change
would include this check, which just slows it down and isn't needed.As a side effect of the confusing options, previously the
bump
command was checking for whether change files are needed, which was odd and probably an artifact ofallowFetching
defaulting to true, not intentional.