Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings] Using SettingsControls #1964

Merged
merged 7 commits into from
Mar 16, 2023
Merged

[Settings] Using SettingsControls #1964

merged 7 commits into from
Mar 16, 2023

Conversation

niels9001
Copy link
Contributor

Fixes #1963

Calc

Description of the changes:

  • Removed the Expander with the new SettingsExpander from the Windows Community Toolkit.
  • Updated the 'About' section to be inline with new design (inline with other inbox apps)

How changes were validated:

  • Navigate to the Settings page.
  • See result.

Zaryob added a commit to Zaryob/calculator that referenced this pull request Mar 4, 2023
@Zaryob
Settings page is redesigned.
f1f61df 
Its a kind of diss to Pull Request microsoft#1964 😄
@Zaryob Zaryob mentioned this pull request Mar 4, 2023
Open
@hanzhang54
Copy link
Contributor

hanzhang54 commented Mar 13, 2023 •
edited
Loading

Would the margin between "Settings" to "Appearance" be too large?
image

@niels9001
Copy link
Contributor Author

@hanzhang54 Good catch! Fixed!

@hanzhang54
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

hanzhang54
hanzhang54 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@hanzhang54 hanzhang54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the excellent contribution! 🎉🎉

@hanzhang54 hanzhang54 merged commit 47f314b into microsoft:main Mar 16, 2023
@hanzhang54 hanzhang54 mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzhang54 hanzhang54 hanzhang54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using SettingsCard & SettingsExpander for the settings screen
2 participants
@niels9001 @hanzhang54