Skip to content

Layout corrections for RTL language environments, including flipped Grapher #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Layout corrections for RTL language environments, including flipped Grapher #2391

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6557485
Added FlowDirection override on Grapher
Avid29 Mar 24, 2022
ae0a347
Merge branch 'microsoft:main' into graph_flow-direction
Avid29 Oct 10, 2025
1ff5e07
Fixed GraphNumPad layout to ensure LTR FlowDirection
Avid29 Oct 10, 2025
0e9bbf2
Fixed EquationIInputArea to still show variables on the left hand sid…
Avid29 Oct 10, 2025
6ff9b8f
Reverted localization changes
Avid29 Oct 16, 2025
ebd8fd9
Merge branch 'microsoft:main' into graph_flow-direction
Avid29 Oct 16, 2025
4c563a6
Fixed encoding on Resources.resw
Avid29 Oct 17, 2025
f55f668
Fixed operator panel scroll button icon directions in RTL
Avid29 Oct 17, 2025
0b4b4f0
Adjusted RightToLeft layout for operators panels
Avid29 Oct 17, 2025
ad8edf8
Revised GraphNumPad to reduce layers of Grids
Avid29 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Calculator/Resources/he-IL/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's still some change. (Maybe it's end-of-line. Could you revert it back?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry. I'd reverted it by hand, so the encoding got changed still. Now I've just copied the file back from main and this should be fully resolved.

<root>
<!--
Microsoft ResX Schema
Expand Down Expand Up @@ -3352,11 +3352,11 @@
<comment>Label text for the step text box</comment>
</data>
<data name="MinTextBlock.Text" xml:space="preserve">
<value>Min</value>
<value>מינימום</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting the translation.
However, these strings are generated by an internal automation tool. We need to report the translation error to the automation team so that they can fix the bot.
Could you please revert the changes of this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I'll report this translation issue to the automation team and they will evaluate whether or not this is an translation error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes. They're both equally valid translations, but the text is next to a TextBox and which side it should be on depends on how that's written. I was playing with automating the flow direction based on the character set but decided that was a bit ridiculous. I forgot to revert the localization file changes afterwards 😬.

Since I've seen this now, I'm going to give another read over to make sure I didn't miss anything else.

Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Hebrew translations for Min/Max labels should include comments explaining the translation choices, similar to other entries in the resource file that have descriptive comments.

Copilot uses AI. Check for mistakes.

<comment>Label text for the min text box</comment>
</data>
<data name="MaxTextBlock.Text" xml:space="preserve">
<value>Max</value>
<value>מקסימום</value>
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Hebrew translations for Min/Max labels should include comments explaining the translation choices, similar to other entries in the resource file that have descriptive comments.

Copilot uses AI. Check for mistakes.

<comment>Label text for the max text box</comment>
</data>
<data name="LineColorText.Text" xml:space="preserve">
Expand Down
3 changes: 2 additions & 1 deletion src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
Style="{ThemeResource VariableContainerStyle}"
contract7Present:CornerRadius="{ThemeResource ControlCornerRadius}">
<StackPanel Padding="12,0,12,6">
<Grid HorizontalAlignment="Stretch">
<Grid HorizontalAlignment="Left"
FlowDirection="LeftToRight">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
Expand Down
1 change: 1 addition & 0 deletions src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@
LosingFocus="GraphingControl_LosingFocus"
LostFocus="GraphingControl_LostFocus"
UseSystemFocusVisuals="True"
FlowDirection="LeftToRight"
VariablesUpdated="GraphingControl_VariablesUpdated">
<graphControl:Grapher.ContextFlyout>
<MenuFlyout Placement="Bottom">
Expand Down
Loading
Loading