Fix(interaction): handle null targets in scroll/click to prevent Type Error #852#1025
Open
BryanBradfo wants to merge 1 commit intomicrosoft:masterfrom
Open
Fix(interaction): handle null targets in scroll/click to prevent Type Error #852#1025BryanBradfo wants to merge 1 commit intomicrosoft:masterfrom
BryanBradfo wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a
TypeErrorreported in issue #852 ("Cannot read properties of null (reading 'scrollLeft')").This error occurs when
scrollLeftorscrollTopis accessed on anullelement, which can happen in certain edge cases (e.g., inside React/Next.js applications where elements might be detached or managing shadow DOM).Changes
I added optional chaining (
?.) and a fallback (|| 0) to handle null targets safely in:packages/clarity-js/src/interaction/scroll.tspackages/clarity-js/src/interaction/click.tspackages/clarity-js/src/interaction/pointer.tsVerification
npm run buildsuccessfully.Fixes #852
cc @AbdelrhmanMagdy (Since you looked into this previously, I thought you might want to review this fix).