Skip to content

Add block scoping to all switch case statements in layout.ts #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add block scoping to all switch case statements in layout.ts #997

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
984020d
ensuring we don't process any script tags that were maliciously uploaded
Dec 10, 2025
de5ab5c
reverting version bump
Dec 10, 2025
796dd43
Initial plan
Copilot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/clarity-visualize/src/layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,13 @@ export class LayoutHelper {
this.setAttributes(iframeElement, node);
insert(node, parent, iframeElement, pivot);
break;
case "SCRIPT":
{
node.id = -1; // We want to ensure children of script tags are not processed
node.value = null; // We don't want to set any potential script content
this.insertDefaultElement(node, parent, pivot, doc, insert);
break;
}
default:
this.insertDefaultElement(node, parent, pivot, doc, insert);
break;
Expand Down