Fix setting of IntDir MSBuild property #1471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building cppwinrt was generating a bunch of warnings like
I tracked this down to us setting
IntDir
too late in Directory.Build.targets, which was too late, and processed after a bunch of other logic. The result of this was thatIntDir
got the default value, which was then used forIntDirFullPath
, and then we overrodeIntDir
.Some MSBuild *.Targets would then use the inconsistent
IntDirFullPath
and complain about folder not being created.To fix this, we now set both
OutDir
andIntDir
consistently, in Directory.Build.Props. Since this left Directory.Build.Targets empty, I'm deleting it.(Also, the old code was using
OutDir
to setIntDir
, and the official docs say "Don't Do That", so we've also got that, which is nice)With all that build spew going away, it should be easier to see the actual warnings we care about.