Skip to content

fix: pass re.DOTALL as keyword arg in Livy comment-stripping regex #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdrakiburrahman merged 1 commit into from
May 19, 2026
Merged

fix: pass re.DOTALL as keyword arg in Livy comment-stripping regex #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dbt/adapters/fabricspark/concurrent_livy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ def _poll(self, submit_response: requests.Response) -> dict:

@staticmethod
def _strip_block_comments(sql: str) -> str:
return re.sub(r"\s*/\*(.|\n)*?\*/\s*", "\n", sql, re.DOTALL).strip()
return re.sub(r"\s*/\*(.|\n)*?\*/\s*", "\n", sql, flags=re.DOTALL).strip()

def execute(self, sql: str, *parameters: Any) -> None:
if len(parameters) > 0:
Expand Down
2 changes: 1 addition & 1 deletion src/dbt/adapters/fabricspark/singleton_livy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def _getLivySQL(self, sql) -> str:
# for the server-side interpreter, so embedded /* ... */ comments are
# stripped here before submission. Client-side escaping is unnecessary
# because submission uses POST JSON, not URL encoding.
code = re.sub(r"\s*/\*(.|\n)*?\*/\s*", "\n", sql, re.DOTALL).strip()
code = re.sub(r"\s*/\*(.|\n)*?\*/\s*", "\n", sql, flags=re.DOTALL).strip()
return code

def _getLivyResult(self, res_obj) -> Response:
Expand Down
Loading