demikernel: v7: series of patches with code improvements - #1599
Merged
Conversation
anandbonde
changed the title
anandbonde
force-pushed
the
ab-code-improvements-v7
branch
3 times, most recently
from
June 28, 2025 18:51
c8cccfd to
b0a73e9
Compare
iyzhang
approved these changes
Jul 8, 2025
Using borrow (&) here would mean that the expression is being borrowed by the callee, however in this case the callee just needs to know the type.
Simplified several complex and unnecssary pieces of code including removing visual clutter, better naming etc.
anandbonde
force-pushed
the
ab-code-improvements-v7
branch
from
July 8, 2025 03:52
b0a73e9 to
8821bf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is v7 of the series of patches that focus on code clarity and simplification. Refer to individual commits for reasoning.