Skip to content

fix: improvement to error handling in the script #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request includes significant changes to the Azure quota checking scripts. The primary changes involve the removal of the quota_check_all_regions.sh script and improvements to error handling in the quota_check_params.sh script.

Removal of quota_check_all_regions.sh script:

  • The entire quota_check_all_regions.sh script has been removed. This script previously fetched Azure subscriptions, checked available regions, and retrieved quota information for various models.

Improvements to error handling in quota_check_params.sh:

  • Added error handling to check if there are no active Azure subscriptions and prompt the user to log in if necessary.
  • Added a check to ensure the subscription ID is not empty before proceeding.

Does this introduce a breaking change?

No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 5f7962b into main Apr 2, 2025
10 checks passed
@Priyanka-Microsoft Priyanka-Microsoft deleted the fix/handled-exceptions-in-the-scripts branch April 3, 2025 12:23
Copy link

github-actions bot commented Apr 5, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants