Skip to content

fix: disable purge protection of keyvault #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Prashant-Microsoft
Copy link

@Prashant-Microsoft Prashant-Microsoft commented Apr 2, 2025

Purpose

This pull request includes updates to the infra/main.json file and infra/deploy_keyvault.bicep file. The changes involve updating the version and template hash for the Bicep generator and removing the enablePurgeProtection property from the Key Vault configuration.

Key changes include:

  • Key Vault Configuration:

    • Removed the enablePurgeProtection property from the Key Vault resource configuration in infra/deploy_keyvault.bicep.
    • Removed the enablePurgeProtection property from the Key Vault configuration in infra/main.json.
  • Bicep Generator Version and Template Hash Updates:

    • Updated the Bicep generator version from 0.33.93.31351 to 0.34.44.8038 and updated the corresponding template hash in multiple locations within infra/main.json. [1] [2] [3] [4] [5] [6] [7] [8]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant