Skip to content

refactor: update naming conventions for resources in Bicep files #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request includes significant changes to the naming conventions in multiple infrastructure files to improve consistency and readability. Additionally, it introduces post-provision hooks in the azure.yaml file.

Naming Convention Changes:

  • infra/deploy_ai_foundry.bicep: Updated various resource names to use a consistent prefix format. For example, storageName changed from ${solutionName}hubstorage to st${solutionName}hub, and aiServicesName changed from ${solutionName}-aiservices to ais-${solutionName}.
  • infra/deploy_app_service.bicep: Modified resource names to follow the new naming convention. For instance, HostingPlanName changed from ${ solutionName }-app-service-plan to asp-${ solutionName }, and WebsiteName changed from ${ solutionName }-app-service to app-${ solutionName }.
  • infra/deploy_cosmos_db.bicep: Changed accountName from ${ solutionName }-cosmos to cosmos-${ solutionName }.
  • infra/deploy_keyvault.bicep: Updated keyvaultName from ${solutionName}-kv to kv-${solutionName}.
  • infra/main.json: Applied the new naming convention across multiple parameters and variables, such as ApplicationInsightsName, WorkspaceName, accountName, and more. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]

Introduction of Post-Provision Hooks:

  • azure.yaml: Added post-provision hooks for both Windows and POSIX environments to display the web app URL after provisioning.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit f759ce1 into main Apr 2, 2025
10 checks passed
@Harsh-Microsoft Harsh-Microsoft deleted the gh-issue-fix-2apr branch April 3, 2025 08:58
Copy link

github-actions bot commented Apr 5, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants