Skip to content

fix: disable purge protection of keyvault #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

Prashant-Microsoft
Copy link

Purpose

This pull request includes changes to the infra directory, specifically in the deploy_keyvault.bicep and main.json files. The changes primarily involve updating the Bicep version and template hashes, as well as modifying Key Vault configurations.

Key Vault configuration changes:

Version and template hash updates:

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

@Roopan-Microsoft Roopan-Microsoft merged commit 7443f70 into dev Apr 8, 2025
4 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the PSL-US-16581 branch April 14, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants