Skip to content

feat: add --models, --regions, and --verbose support #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request includes several updates to the scripts/quota_check_params.sh script, primarily focusing on adding new parameters for models, regions, and verbosity, as well as improving the logging mechanism. The most important changes include the addition of command-line options, the introduction of a verbose logging function, and updates to the handling of user-provided parameters.

New Command-Line Options and Parameters:

  • Added support for --models, --regions, and --verbose command-line options to allow users to specify models, regions, and enable verbose logging.

Improved Logging Mechanism:

  • Introduced a log_verbose function to handle conditional logging based on the verbosity setting. Updated various echo statements to use log_verbose for better control over log output. [1] [2] [3] [4]

Handling User-Provided Parameters:

  • Modified the script to read user-provided models and regions from the new command-line options instead of positional parameters. This change improves flexibility and usability.

Formatting Adjustments:

  • Adjusted the formatting of the output table to ensure alignment and readability, especially when verbose logging is enabled. [1] [2]

Does this introduce a breaking change?

No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

- Integrated a  flag to enable detailed logging for easier troubleshooting.
@Roopan-Microsoft Roopan-Microsoft merged commit e435f73 into main Apr 14, 2025
10 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the enhancement/azure-script-verbose-model-region-params branch April 14, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants