feat: Centralize resource name abbreviations and update Bicep files for consistent naming #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a centralized JSON file (
abbreviations.json
) to manage resource name abbreviations and updates various Bicep deployment files to use these abbreviations. This change simplifies resource naming conventions and ensures consistency across the infrastructure codebase.Centralized Abbreviation Management:
infra/abbreviations.json
to define a comprehensive mapping of resource types to their abbreviations, categorized by themes such as AI, analytics, compute, databases, and more.Updates to Resource Naming in Bicep Files:
infra/deploy_ai_foundry.bicep
to replace hardcoded resource names with dynamic names derived fromabbreviations.json
. This includes variables likestorageName
,aiServicesName
,applicationInsightsName
, and others.infra/deploy_app_service.bicep
to use abbreviations forHostingPlanName
andWebsiteName
, ensuring consistent naming. [1] [2]infra/deploy_cosmos_db.bicep
to use the abbreviation for Cosmos DB account names.infra/deploy_keyvault.bicep
to derive the Key Vault name dynamically from the abbreviation file.infra/deploy_managed_identity.bicep
andinfra/deploy_storage_account.bicep
for managed identity and storage account names, respectively. [1] [2]Minor Adjustments:
statisticsEnabled
property in theaiServices
resource definition ininfra/deploy_ai_foundry.bicep
.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information