-
Notifications
You must be signed in to change notification settings - Fork 51
Add API for In-process Testing and Add Class-Syntax Integration Tests #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Is the goal of this feature to ship it as a public package for other developers to use? If so, we should put this in its own project and make it into a nuget package. But let me know if that was the intention here, or if it's something different. |
<AssemblyName>Microsoft.DurableTask.InProcessTestHost</AssemblyName> | ||
<PackageId>Microsoft.DurableTask.InProcessTestHost</PackageId> | ||
<EnableStyleCop>false</EnableStyleCop> | ||
<NoWarn>$(NoWarn);CS1591</NoWarn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this warning that we're supressing? Can we add a comment here to explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh it's just these moved files have so many format warnings... I tried to fix all but didn't finish. So, I just suppress it for now. But I will fix all of them ...
/// </summary> | ||
public class ClassSyntaxIntegrationTests : IntegrationTestBase | ||
{ | ||
public ClassSyntaxIntegrationTests(ITestOutputHelper output, GrpcSidecarFixture sidecarFixture) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the GrpcSidecarFixture
using the new test host internally?
<TargetFramework>net6.0</TargetFramework> | ||
<RootNamespace>Microsoft.DurableTask.Testing</RootNamespace> | ||
<AssemblyName>Microsoft.DurableTask.InProcessTestHost</AssemblyName> | ||
<PackageId>Microsoft.DurableTask.InProcessTestHost</PackageId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we have a separate versioning scheme for this package, and start it with 0.1.0-preview.1.
This is important for allowing us to make breaking changes while we stabilize it. Once we see that users are successfully adopting it, we can remove the preview suffix.
This PR Introduce a new api and package
DurableTaskTestHost
for customer to test their orchestrations in-process