[netebpfext] Add per-provider WFP handles to avoid improper use from parallel invocations #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewige
changed the title
matthewige
changed the title
matthewige
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
mtfriesen and
rectified95
as code owners
shankarseal
reviewed
Sep 28, 2024
shankarseal
reviewed
Sep 28, 2024
shankarseal
reviewed
Sep 28, 2024
shankarseal
reviewed
Sep 28, 2024
| @@ -539,6 +581,9 @@ _net_ebpf_ext_register_wfp_callout(_Inout_ net_ebpf_ext_wfp_callout_state_t* cal | |||
| callout_register_state.flags = 0; | |||
|
|
|||
| status = FwpsCalloutRegister(device_object, &callout_register_state, &callout_state->assigned_callout_id); | |||
| if (WFP_ERROR(status, ALREADY_EXISTS)) { | |||
There was a problem hiding this comment.
nit: in what case can it already exist?
There was a problem hiding this comment.
reboot without driver being unloaded - such as kernel crash or power failure.
There was a problem hiding this comment.
Come to think of it, since FWPM_*_FLAG_PERSISTENT is not passed for any objects; none of these objects should remain after a reboot. You were likely hitting this during your intermediate testing. I think this check can be safely removed.
shankarseal
previously approved these changes
Oct 2, 2024
…ks with asserts, remove unneded helper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
Our KM stress tests revealed an issue in our netebpfext code. There is a single global WFP handle, but multiple threads could use this at the same time (such as two programs attaching in parallel), leading to errors in the WFP APIs.
Fix:
Closes #3607
Testing
Existing tests validate this functionality.
Documentation
None.
Installation
None.