small updates to llama model class #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds support for multi-turn conversations to all the model APIs that support it. (***Gemini API is the only model that either does not take a list of messages, or I haven't figured it out yet.) - Also adds support for Azure authorization scope to be configured via model config. --------- Co-authored-by: Safoora Yousefi <[email protected]>
safooray
requested changes
Dec 17, 2024
| @@ -292,7 +292,8 @@ def create_request(self, text_prompt, query_images=None, *args, **kwargs): | |||
| user_content = {"role": "user", "content": text_prompt} | |||
| if query_images: | |||
| if len(query_images) > 1: | |||
| raise ValueError("Llama vision model does not support more than 1 image.") | |||
| logging.warning("Llama vision model does not support more than 1 image.") | |||
There was a problem hiding this comment.
Have you tested this? Return None from create_request, passes the None to get_response and I'm not sure how urllib.request.urlopen behaves if Request object is None.
As we discussed, please adjust this return value in a way that you can handle the situation properly in handle_request_error, and return do_return True so the request does not get attempted again.
Fixes circular import in data_utils --------- Co-authored-by: Safoora Yousefi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small updates to LlamaServerlessAzureRestEndpointModel class in models.py while creating request.