Allow for duplicate search parameters #3790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feordin
changed the title
feordin
force-pushed
the
personal/jaerwin/search-params
branch
from
8d40931 to
5ed7eb5
Compare
feordin
added
Bug
feordin
changed the title
feordin
added
Azure API for FHIR
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Fixed
Show fixed
Hide fixed
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Fixed
Show fixed
Hide fixed
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Fixed
Show fixed
Hide fixed
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Fixed
Show fixed
Hide fixed
Comment on lines
+162
to
+175
| catch (Exception exp) | ||
| { | ||
| _output.WriteLine($"Attempt {retryCount} of {MaxRetryCount}: CustomSearchParameter test experienced issue attempted to clean up SearchParameter {searchParam.Url}. The exception is {exp}"); | ||
| if (exp is FhirClientException fhirException && fhirException.OperationOutcome?.Issue != null) | ||
| { | ||
| foreach (OperationOutcome.IssueComponent issueComponent in fhirException.OperationOutcome.Issue) | ||
| { | ||
| _output.WriteLine("FhirException OperationOutome message from trying to delete SearchParameter is CustomSearchParam test: {0}", issueComponent.Diagnostics); | ||
| } | ||
| } | ||
|
|
||
| success = false; | ||
| await Task.Delay(TimeSpan.FromSeconds(10)); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note test
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Fixed
Show fixed
Hide fixed
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Fixed
Show fixed
Hide fixed
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Dismissed
Show dismissed
Hide dismissed
...ealth.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterConflictingCodeValidator.cs
Dismissed
Show dismissed
Hide dismissed
| // for the search parameter/reindex updates to propagate to all instances. Hence we are | ||
| // adding some retries below to account for that delay. | ||
| int retryCount = 0; | ||
| bool success = true; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning test
| } | ||
| if (!supportedResult.Supported) | ||
| { | ||
| throw new SearchParameterNotSupportedException(searchParameterInfo.Url); |
There was a problem hiding this comment.
Customer sees this message "The search parameter with definition URL '{0}' is not supported.". I know this change is not related to this PR but in this scenario, error is thrown if definition has any issues. Do you think we can use better error message to indicate customer that something is wrong with the definition they have sent?
| await _searchParameterStatusManager.AddSearchParameterStatusAsync( | ||
| new List<string> { searchParameterWrapper.Url }, | ||
| cancellationToken, | ||
| duplicateSearchParameter ? SearchParameterStatus.Duplicate : SearchParameterStatus.Supported); |
There was a problem hiding this comment.
We are introducing a new status Duplicate here. How is it going to impact reindex and $status operation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are published IG's with Search Parameters that have identical code values and expression as existing Search Parameters. We want to allow these parameters without causing any reindexing or ambiguous behaviors when searching using the duplicated code values.
This PR also blocks the addition of any Search Parameter resource with a conflicting code value that has a different expression. As this is a bug that currently puts the service into an unstable state.
Related issues
Addresses [issue AB#117004].
Testing
Unit tests are added.
Manual testing using UploadFIG with USCore is done, and all SearchParameters succeeded.
Still TBD: E2E test to check reindex impact.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)