Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ordering to reindex surrogate id fetch #4686

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Oct 17, 2024

Description

When an empty page is encountered w/ reindex, the next page processed isn't the next page - it skips records. The order by ensures pages of data are processed in order.

Related issues

AB#130486

Testing

Debugging database, seeing unordered list causing data to be skipped. Manual testing on DB planned.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner October 17, 2024 16:04
@mikaelweave mikaelweave added Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. labels Oct 17, 2024
@mikaelweave mikaelweave added this to the S152 milestone Oct 17, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave added the Area-Operations Area related to operations. label Oct 17, 2024
@mikaelweave
Copy link
Contributor Author

mikaelweave commented Oct 17, 2024

CleanShot 2024-10-17 at 13 43 11

Confirmed by reindex on problematic db

@mikaelweave mikaelweave merged commit eb645fa into main Oct 17, 2024
47 of 51 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/reindex-skipped-pages branch October 17, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Operations Area related to operations. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants