add ordering to reindex surrogate id fetch #4686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an empty page is encountered w/ reindex, the next page processed isn't the next page - it skips records. The order by ensures pages of data are processed in order.
Related issues
AB#130486
Testing
Debugging database, seeing unordered list causing data to be skipped. Manual testing on DB planned.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)