Skip to content

Comments

Add index hint for reference search#4719

Closed
feordin wants to merge 1 commit intomainfrom
personal/jaerwin/reference-index-hint
Closed

Add index hint for reference search#4719
feordin wants to merge 1 commit intomainfrom
personal/jaerwin/reference-index-hint

Conversation

@feordin
Copy link
Contributor

@feordin feordin commented Nov 11, 2024

Description

When searching for a reference value, sometimes SQL will fail to generate an optimal query plan and use the proper index on the table. This will add a hint to better ensure proper query plan generation.

Related issues

Addresses [issue AB#132348].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@feordin feordin added Enhancement Enhancement on existing functionality. Area-SQL Area related to the SQL Server data provider Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Nov 11, 2024
@feordin feordin added this to the S153 milestone Nov 11, 2024
@feordin feordin requested a review from a team as a code owner November 11, 2024 05:05
ResourceVersionTypes = ResourceVersionType.Latest,
};

var output = _queryGenerator.VisitSqlRoot(sqlExpression, searchOptions);

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This assignment to [output](1) is useless, since its value is never read.
@feordin feordin closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-SQL Area related to the SQL Server data provider Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants