Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index hint for reference search #4719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

feordin
Copy link
Contributor

@feordin feordin commented Nov 11, 2024

Description

When searching for a reference value, sometimes SQL will fail to generate an optimal query plan and use the proper index on the table. This will add a hint to better ensure proper query plan generation.

Related issues

Addresses [issue AB#132348].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@feordin feordin added Enhancement Enhancement on existing functionality. Area-SQL Area related to the SQL Server data provider Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Nov 11, 2024
@feordin feordin added this to the S153 milestone Nov 11, 2024
@feordin feordin requested a review from a team as a code owner November 11, 2024 05:05
ResourceVersionTypes = ResourceVersionType.Latest,
};

var output = _queryGenerator.VisitSqlRoot(sqlExpression, searchOptions);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
output
is useless, since its value is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-SQL Area related to the SQL Server data provider Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants