Skip to content

Support multiple pages of include results in bulk delete #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025

Conversation

LTA-Thinking
Copy link
Contributor

@LTA-Thinking LTA-Thinking commented May 5, 2025

Description

Add full support for using _include and _revinclude with bulk delete.
The functionality to report when bulk delete detects a miscount has been removed as it doesn't work with the include feature and was of limited value.

Related issues

Addresses User Story 135884

Testing

To be added

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch

@LTA-Thinking LTA-Thinking added this to the CY25Q2/2Wk03 milestone May 5, 2025
@LTA-Thinking LTA-Thinking added Enhancement Enhancement on existing functionality. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels May 5, 2025
@LTA-Thinking LTA-Thinking changed the title Personal/rojo/bulk delete all include Support multiple pages of include results in bulk delete May 5, 2025
@LTA-Thinking LTA-Thinking marked this pull request as ready for review May 15, 2025 21:04
@LTA-Thinking LTA-Thinking requested a review from a team as a code owner May 15, 2025 21:04
@LTA-Thinking LTA-Thinking enabled auto-merge (squash) May 15, 2025 22:05
@LTA-Thinking LTA-Thinking merged commit 9a83305 into main May 22, 2025
47 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/bulk-delete-all-include branch May 22, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants