[DataGrid] Fix resize indicator height (when ResizeColumnOnAllRows is true) #4383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the height calculation for the resize indicator in the DataGrid component when ResizeColumnOnAllRows is set to true (issue #4378). The fix involves removing excessive padding from header cells and adjusting the positioning logic to properly align the resize handle.
Key changes:
- Removed CSS padding from column headers that was causing incorrect height calculations
- Adjusted min-height from 44px to 40px to compensate for the removed padding
- Updated resize handle positioning to be dynamically calculated based on the actual offset and DataGridDisplayMode
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| FluentDataGridCell.razor.css | Removed padding from .column-header class to fix height calculation |
| FluentDataGridCell.razor.cs | Reduced min-height from 44px to 40px to account for removed padding |
| FluentDataGrid.razor.js | Updated resize handle creation logic to dynamically calculate top position and adjusted height calculations |
| FluentDataGrid.razor.css | Removed hardcoded top: 5px from .resize-handle to allow dynamic positioning |
| FluentDataGrid.razor | Added dynamic top position calculation based on DataGridDisplayMode (4px for Table, 2px for Grid) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…crosoft/fluentui-blazor into users/vnbaaij/fix-issue-#4378
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.3%
|
…crosoft/fluentui-blazor into users/vnbaaij/fix-issue-#4378
dvoituron
approved these changes
Dec 8, 2025
vnbaaij
added a commit
that referenced
this pull request
Dec 12, 2025
…lRows is true) (#4392) * Port #4383 to v5 * Update verified files * Remove IssueTester work. We'll do that later * Process comments --------- Co-authored-by: Denis Voituron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4378. The height calculation was don alright already by the header height was set too high because of a padding value. The padding has now been removed. Because of the removed padding, the top of the resize indicator needs to be set dependent on the DataGridDisplayMode