-
Notifications
You must be signed in to change notification settings - Fork 460
[ProfileMenu] Change tabindex to 0 #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an accessibility issue by changing the tabindex attribute in FluentProfileMenu from "1" to "0", allowing the component to follow the natural tab order instead of forcing a custom order.
- Changed hardcoded
tabindex="1"totabindex="0"in the FluentProfileMenu component - Updated all snapshot test files to reflect the new tabindex value
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/Components/ProfileMenu/FluentProfileMenu.razor | Updated the tabindex attribute from "1" to "0" in the root div element |
| tests/Core/ProfileMenu/FluentProfileMenuTests.FluentProfileMenu_Default.verified.razor.html | Updated snapshot test to verify tabindex="0" |
| tests/Core/ProfileMenu/FluentProfileMenuTests.FluentProfileMenu_Customized.verified.razor.html | Updated snapshot test to verify tabindex="0" |
| tests/Core/ProfileMenu/FluentProfileMenuTests.FluentProfileMenu_StartEndTemplate.verified.razor.html | Updated snapshot test to verify tabindex="0" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.3%
|
Fix #4397. The
FluentProfileMenuused a hard-codedtabindexattribute value of1(see #4104), This PR sets it to use0PS - I did a search on the rest of the codebase. We do not use a value of
1anywhere else.