[dev-v5] Migrate PullToRefresh component

[PascalVorwerk]

Pull Request

📖 Description

#4185

I've tried to keep the functionality 1 on 1 as much as possible. Some things that i changed:

• Had to change the samples a little bit because of deprecation and no Listbox yet in this version.
• Javascript file made with the name spacing like in other javascript files.
• The PullingTemplate was not being shown when there was a custom template. It used to be set in the Oninitialized, now its set in the OnParametersSet, seems to work better.
• Had to change some styling variables, trying to find the most common looking variable in the new system.

I was not sure if you guys wanted to try 'new' things or set up things differently in v5, but it was a nice practice for me, let me know if you wanted to start from scratch, then i will close this PR.

📑 Test Plan

Test out the component in the demo page "PullToRefresh"

✅ Checklist

General

• I have added tests for my changes.
• I have tested my changes.
• I have updated the project documentation to reflect my changes.
• I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

• I have added a new component
• I have added Unit Tests for my new component

[vnbaaij]

Think this is pretty good already. Thanks!
Need to take a closer look at a pc still

[vnbaaij]

@PascalVorwerk we have a line coverage threshold set of 98%. For this PR the percentage is now at 97.3%. So, the build action here on GitHub fails.

The coverage for the PullToRefresh is only at 37% so a lot more tests are needed...

You can generate a coverage report with the _StartCodeCoverage.cmd in the tests\Core folder

[PascalVorwerk]

@PascalVorwerk we have a line coverage threshold set of 98%. For this PR the percentage is now at 97.3%. So, the build action here on GitHub fails.

The coverage for the PullToRefresh is only at 37% so a lot more tests are needed...

You can generate a coverage report with the _StartCodeCoverage.cmd in the tests\Core folder

Yep i noticed haha, i was working in Rider and sadly don't have .dotCover, but working in vs code it gives me a better idea of where i am still missing coverage. Working on it now!

[PascalVorwerk]

I'm not sure why some tests are failing now, they are not tests i touched or changed i believe (An overlay test and a Listbox test).

[vnbaaij]

Happens sometimes. Usually running again fixes that.

[MarvinKlein1508]

Tested it in Firefox.