[dev-v5] [Docs] Set FluentNav height 100% #4463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR sets the height of the
FluentNavin the docs to 100%. Without this the sidebar would not show the dark background color when the content fits into the container.For example ( I zoomed out here to show it):
Before:

After:

It gets more clear when you see a real example. This is the current v5 of the community components where the navigation is still very small.
Before:

After:

In theory this isn't necessary at all. But I thought it might be useful for other developers when they try to built the same navigation from the docs (at least it helped me). I tested in in Egde, Chrome and Firefox.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps