Skip to content

Conversation

@MarvinKlein1508
Copy link
Collaborator

Pull Request

📖 Description

This PR sets the height of the FluentNav in the docs to 100%. Without this the sidebar would not show the dark background color when the content fits into the container.

For example ( I zoomed out here to show it):

Before:
grafik

After:
grafik

It gets more clear when you see a real example. This is the current v5 of the community components where the navigation is still very small.

Before:
grafik

After:
grafik

In theory this isn't necessary at all. But I thought it might be useful for other developers when they try to built the same navigation from the docs (at least it helped me). I tested in in Egde, Chrome and Firefox.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@dvoituron dvoituron enabled auto-merge (squash) January 13, 2026 11:26
@dvoituron dvoituron merged commit 6298786 into microsoft:dev-v5 Jan 13, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants