Merged
Conversation
Closed
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the SelectColumn's initial state was not displayed correctly when using the Property parameter (instead of SelectedItems) with items that were already in a selected state.
Changes:
- Modified the
GetSelectAll()method to check thePropertyparameter against grid items to determine initial selection state - Changed the default value of
SelectAllfromfalsetonullto allow proper state calculation - Fixed a spelling error in the demo example ("Peoples" → "People")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/Components/DataGrid/Columns/SelectColumn.cs | Fixed initial state detection by checking Property parameter against grid items; changed SelectAll default from false to null |
| examples/Demo/Shared/Pages/DataGrid/Examples/DataGridMultiSelect.razor | Corrected spelling from "Peoples:" to "People:" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (InternalGridContext != null && (Grid.Items != null || Grid.ItemsProvider != null)) | ||
| { | ||
| if (_selectedItems.Count == 0) | ||
| if (_selectedItems.Count == 0 && !InternalGridContext.Items.Any(Property)) |
There was a problem hiding this comment.
The call to InternalGridContext.Items.Any(Property) iterates through all items in the grid each time GetSelectAll() is invoked. For large datasets, this could impact performance. Consider caching this result or using an alternative approach if RefreshHeaderContent() is called frequently. However, since RefreshHeaderContent() is only called when selection state changes, this may be acceptable for most use cases.
dvoituron
approved these changes
Jan 30, 2026
vnbaaij
added a commit
that referenced
this pull request
Jan 30, 2026
vnbaaij
added a commit
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not using
SelectedItems, the initial state would not be displayed correctly is any item was actually in a selected state. This PR fixes that by including a check on the thePropertyparameter of the (InternalGridContext)Items