Merged
Conversation
- Do not redirect to homepage whne dismiss link is clicked
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the notification center demo so the “Dismiss all” control behaves correctly and only appears when relevant.
Changes:
- Wraps the “Dismiss all”
FluentAnchorin a conditional block so it only renders when there are notifications (MessageService.Count(App.MESSAGES_NOTIFICATION_CENTER) > 0). - Updates the
Hrefon the “Dismiss all” link from an empty string to"#"to avoid redirecting to the site root when clicked.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
dvoituron
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4492
This pull request makes a small but important change to the
NotificationCenterPanel.razorcomponent. Now, the "Dismiss all" link will only be shown if there are notifications present in the notification center, improving the user experience by hiding unnecessary actions. Also, the link does not redirect to the homepage anymore.NotificationCenterPanel.razorso that the "Dismiss all" anchor is only rendered when there are notifications to dismiss.