Skip to content

docs(docsite): fix ColorVariants story 'Show code' to follow index re-export pattern #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hotell wants to merge 1 commit into from
Closed

docs(docsite): fix ColorVariants story 'Show code' to follow index re-export pattern #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions packages/docsite/stories/Icons/ColorVariants/ColorVariants.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import { CalendarColor } from '@fluentui/react-icons';
import { Body1Stronger, makeStyles, shorthands, tokens } from '@fluentui/react-components';
import * as React from 'react';

const useClasses = makeStyles({
root: {
display: 'flex',
...shorthands.gap('32px'),
},
column: {
display: 'flex',
flexDirection: 'column',
...shorthands.gap('8px'),
...shorthands.padding('12px'),
...shorthands.border('1px', 'solid', tokens.colorNeutralStroke2),
borderRadius: tokens.borderRadiusMedium,
},
icons: {
fontSize: '48px',
},
// Hiding one instance with display:none triggers the gradient ID collision
// for any sibling that shares the same (unscoped) IDs.
hidden: {
display: 'none',
},
});

export const ColorIdPrefix = () => {
const classes = useClasses();

return (
<div className={classes.root}>
<div className={classes.column}>
<Body1Stronger>❌ Without idPrefix</Body1Stronger>
<div className={classes.icons}>
<CalendarColor className={classes.hidden} aria-hidden />
<CalendarColor aria-label="Calendar without idPrefix" />
</div>
</div>

<div className={classes.column}>
<Body1Stronger>✅ With idPrefix</Body1Stronger>
<div className={classes.icons}>
<CalendarColor idPrefix="cal-a-" className={classes.hidden} aria-hidden />
<CalendarColor idPrefix="cal-b-" aria-label="Calendar with idPrefix" />
</div>
</div>
</div>
);
};
49 changes: 1 addition & 48 deletions packages/docsite/stories/Icons/ColorVariants/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,56 +1,9 @@
import { CalendarColor } from '@fluentui/react-icons';
import { Body1Stronger, makeStyles, shorthands, tokens } from '@fluentui/react-components';
import { Controls, Description, Primary, Title } from '@storybook/addon-docs/blocks';
import * as React from 'react';

import descriptionMd from './ColorVariantsDescription.md';

const useClasses = makeStyles({
root: {
display: 'flex',
...shorthands.gap('32px'),
},
column: {
display: 'flex',
flexDirection: 'column',
...shorthands.gap('8px'),
...shorthands.padding('12px'),
...shorthands.border('1px', 'solid', tokens.colorNeutralStroke2),
borderRadius: tokens.borderRadiusMedium,
},
icons: {
fontSize: '48px',
},
// Hiding one instance with display:none triggers the gradient ID collision
// for any sibling that shares the same (unscoped) IDs.
hidden: {
display: 'none',
},
});

export const ColorIdPrefix = () => {
const classes = useClasses();

return (
<div className={classes.root}>
<div className={classes.column}>
<Body1Stronger>❌ Without idPrefix</Body1Stronger>
<div className={classes.icons}>
<CalendarColor className={classes.hidden} aria-hidden />
<CalendarColor aria-label="Calendar without idPrefix" />
</div>
</div>

<div className={classes.column}>
<Body1Stronger>✅ With idPrefix</Body1Stronger>
<div className={classes.icons}>
<CalendarColor idPrefix="cal-a-" className={classes.hidden} aria-hidden />
<CalendarColor idPrefix="cal-b-" aria-label="Calendar with idPrefix" />
</div>
</div>
</div>
);
};
export { ColorIdPrefix } from './ColorVariants.stories';

export default {
title: 'Icons/Color Variants',
Expand Down
Loading